Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Use BuildBuddy for Bazel results, remote caching, and remote execution #1840

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented Oct 8, 2024

This greatly speeds up builds and provides a detailed UI for results. See https://buildbuddy.io/

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas changed the base branch from sanjayvas-spanner-model-rollouts to main October 8, 2024 19:53
@SanjayVas SanjayVas force-pushed the sanjayvas-buildbuddy branch 3 times, most recently from 9381d71 to 14b384c Compare October 8, 2024 21:34
@SanjayVas SanjayVas force-pushed the sanjayvas-buildbuddy branch 15 times, most recently from a3b77f2 to 221d5e1 Compare October 23, 2024 00:34
@SanjayVas SanjayVas marked this pull request as ready for review October 23, 2024 00:36
@SanjayVas
Copy link
Member Author

I've already run this by @TNATALI and @kungfucraig

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what kind of performance gains are you seeing?

Reviewed 4 of 31 files at r1, all commit messages.
Reviewable status: 4 of 31 files reviewed, all discussions resolved

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can compare all the runs on this branch to runs outside of this branch to see.

Even the cache itself is faster, so a fully cached run on main took 19m where the one on this branch took 5m.

Reviewable status: 4 of 31 files reviewed, all discussions resolved (waiting on @stevenwarejones)

Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 27 of 31 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-buildbuddy branch from 221d5e1 to 7129340 Compare October 23, 2024 16:03
@SanjayVas SanjayVas force-pushed the sanjayvas-buildbuddy branch from 7129340 to 0a10ce1 Compare October 23, 2024 16:52
@SanjayVas SanjayVas merged commit d41374d into main Oct 23, 2024
4 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-buildbuddy branch October 23, 2024 17:14
SanjayVas added a commit that referenced this pull request Oct 28, 2024
…1876)

The `ci` Bazel configuration enables remote execution and caching via BuildBuddy. There was some missing configuration in #1840 which prevents the `update-cmms` workflow from completing successfully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants