Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update google API clients for compatibility with google-api-client. #1411

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented Jan 10, 2024

The version compatibility should ideally be handled by Maven artifact resolution (meaning google-api-services-storage < 2 should require google-api-client < 2). Alas it is not, so this works around the issue by specifying the version explicitly.

Closes #1410

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas marked this pull request as ready for review January 10, 2024 20:47
@SanjayVas SanjayVas force-pushed the sanjayvas-google-api-client branch from 7132ae9 to e414376 Compare January 10, 2024 21:57
@SanjayVas SanjayVas changed the title Update google-api-services-storage for compatibility with google-api-client. Update google API clients for compatibility with google-api-client. Jan 10, 2024
@SanjayVas SanjayVas force-pushed the sanjayvas-google-api-client branch from e414376 to 13c41a5 Compare January 10, 2024 22:04
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas force-pushed the sanjayvas-google-api-client branch from 13c41a5 to c1f29c4 Compare January 11, 2024 22:21
@SanjayVas SanjayVas enabled auto-merge (squash) January 11, 2024 22:21
@SanjayVas SanjayVas merged commit dbd6df5 into main Jan 11, 2024
5 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-google-api-client branch January 11, 2024 23:13
ple13 pushed a commit that referenced this pull request Aug 16, 2024
…1411)

The version compatibility should ideally be handled by Maven artifact resolution (meaning google-api-services-storage < 2 should require google-api-client < 2). Alas it is not, so this works around the issue by specifying the version explicitly.

Closes #1410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Postgres-based internal API servers will not start due to client mismatch
3 participants