Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command Line Tool Supports Creation of Reach-Only Measurements. #1188

Closed
wants to merge 3 commits into from

Conversation

renjiezh
Copy link
Contributor

No description provided.

@renjiezh renjiezh marked this pull request as draft August 29, 2023 17:51
@wfa-reviewable
Copy link

This change is Reviewable

@renjiezh renjiezh marked this pull request as ready for review August 29, 2023 17:56
@renjiezh renjiezh requested a review from SanjayVas August 30, 2023 16:52
Copy link
Member

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r2, all commit messages.
Reviewable status: 1 of 3 files reviewed, 2 unresolved discussions (waiting on @renjiezh)


src/main/kotlin/org/wfanet/measurement/api/v2alpha/tools/MeasurementSystem.kt line 653 at r2 (raw file):

    class ReachOnlyParams {
      @Option(
        names = ["--reach-only"],

We can just reference "reach" here, as that's the underlying Measurement type. The "reach only" distinction is only to differentiate the new protocol from the existing R/F LLv2 protocol.

Suggestion:

--reach

src/main/kotlin/org/wfanet/measurement/api/v2alpha/tools/MeasurementSystem.kt line 659 at r2 (raw file):

      var selected = false

      @set:Option(

What happens if you factor these options into another class and use @Mixin to put it inside of both ReachParms and ReachAndFrequencyParams?

@renjiezh
Copy link
Contributor Author

Replaced by #1254

@renjiezh renjiezh closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants