Update Benchmark and MeasurementSystem with population results

[stevenwarejones]

• Adds population flags to Create Measurement including refactoring all Event-specific flags under EventMeasurementParams
• Consolidates flags from MeasurementSystem and Benchmark in CreateMeasurementFlags
• Fixes a bug in BenchmarkTest that wasn't actually returning the correct result for each measurement and was verifying the wrong thing. Note: This behavior still exists in MeasurementSystemTest but since we aren't verifying any results, this seems unimportant to fix at this time.

[wfa-reviewable]

This change is 

[SanjayVas]

Thanks for the refactoring and fixes!

@renjiezh for changes to Benchmark

Reviewed 24 of 24 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @renjiezh and @stevenwarejones)

---

src/main/kotlin/org/wfanet/measurement/api/v2alpha/tools/BUILD.bazel line 30 at r2 (raw file):

    name = "measurement_system",
    srcs = [
        "CreateMeasurementFlags.kt",

Source files should not be referenced by more than one library target. Create a separate kt_jvm_library for this source file and add it to the deps of both measurement_system and benchmark_library.

Code quote:

 "CreateMeasurementFlags.kt",

[renjiezh]

FYI, there are 2 PRs having merging conflict with this one.
#1188
#1183

Reviewed 24 of 24 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @stevenwarejones)

---

src/test/kotlin/org/wfanet/measurement/api/v2alpha/tools/MeasurementSystemTest.kt line 1984 at r2 (raw file):

        state = Measurement.State.SUCCEEDED

        results += resultPair {

Could you add a TODO here to remind me to merge results into one object.

[stevenwarejones]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/api/v2alpha/tools/BUILD.bazel line 30 at r2 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Source files should not be referenced by more than one library target. Create a separate kt_jvm_library for this source file and add it to the deps of both measurement_system and benchmark_library.

Done.

[SanjayVas]

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @stevenwarejones)

---

src/main/kotlin/org/wfanet/measurement/api/v2alpha/tools/CreateMeasurementFlags.kt line 92 at r3 (raw file):

        )
        lateinit var name: String
          set

These should all have private set as they are only set by Picocli CommandLine injection.

---

src/test/kotlin/org/wfanet/measurement/api/v2alpha/tools/MeasurementSystemTest.kt line 1978 at r3 (raw file):

    }

    // TODO: Have separate successful measurements for each measurement type

Use KDoc syntax for properties. See https://developer.android.com/kotlin/style-guide#documentation

If possible, indicate a context for TODOs. See https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/docs/code-style.md#todos

[stevenwarejones]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SanjayVas)

---

src/main/kotlin/org/wfanet/measurement/api/v2alpha/tools/CreateMeasurementFlags.kt line 92 at r3 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

These should all have private set as they are only set by Picocli CommandLine injection.

Done.

---

src/test/kotlin/org/wfanet/measurement/api/v2alpha/tools/MeasurementSystemTest.kt line 1978 at r3 (raw file):

Previously, SanjayVas (Sanjay Vasandani) wrote…

Use KDoc syntax for properties. See https://developer.android.com/kotlin/style-guide#documentation

If possible, indicate a context for TODOs. See https://github.com/world-federation-of-advertisers/cross-media-measurement/blob/main/docs/code-style.md#todos

Done.

[SanjayVas]

Reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @stevenwarejones)