Ipc/account saving #129
Merged
Ipc/account saving #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
Signed-off-by: Sven Dowideit <[email protected]>
SvenDowideit
commented
May 19, 2022
| @@ -291,6 +282,15 @@ function ProgramChangeView() { | |||
| <Button | |||
| onClick={() => { | |||
| const newAccount = createNewAccount(); | |||
| // TODO: yeah, this is horrible, will be easier to do generating the new Key on the server, and saving it there... | |||
There was a problem hiding this comment.
This will change in a future PR that actually moves it - but there's wallet work I need to do first to make that worth it.
This was referenced May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using the new PromiseIPC config store for human name editing - though I'm using it as a description.
and
and we also know and save (and show the user) the private key when creating a new Keypair through the WB