Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save any private keys in a safe place #80

Closed
SvenDowideit opened this issue Apr 7, 2022 · 3 comments
Closed

save any private keys in a safe place #80

SvenDowideit opened this issue Apr 7, 2022 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@SvenDowideit
Copy link
Member

SvenDowideit commented Apr 7, 2022

we have a create account function, but atm, the private key isn't saved - it used to be sent to the electron main process to be saved and passed back.

I hope we can talk to a wallet, and preferably client side, but for the electron app, that may not be possible yet.

Reading the code&examples, I get the strong feeling that we should not be doing account mutating transactions in the client directly - it should really use wallet-adapter, for which we should implement an electron ipc adapter, which then delegates the work - that way, the private keys would (initially) be handled only by the main app, and later by our out of GUI process daemon.

This then gives us a zero-steps ability to function, but giving the user the choice to use a real wallet.

@SvenDowideit
Copy link
Member Author

I'm going to push the wallet stuff to 0.4.0

@SvenDowideit
Copy link
Member Author

#129 starts towards this - by (just) sending and saving the private key to the electron main process.
Once wallet-adapter support is done, I'll work towards offloading all signing duties to the wallet.

@SvenDowideit
Copy link
Member Author

this is functional, but will want later UX improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant