Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2.0.0 into trunk #304

Merged
merged 36 commits into from
Oct 20, 2021
Merged

Release 2.0.0 into trunk #304

merged 36 commits into from
Oct 20, 2021

Conversation

AliSoftware
Copy link
Contributor

@AliSoftware AliSoftware commented Oct 19, 2021 •
edited
Loading

New version 2.0.0.

Next Steps once this PR gets merged (ref: paaHJt-2d8-p2):

  • Create a GitHub Release and tag (pointing to trunk)
  • Announce the new tagged version to our build-and-ship channel

Side note: updating the client apps to this 2.0.0 once released should be straightforward as, even if it's a major version (with breaking changes), the only changes that this breaks were only used in WPAndroid (which is already ready for this version), not any other client app.

AliSoftware and others added 30 commits August 4, 2021 22:22
@AliSoftware
Merge pull request #292 from wordpress-mobile/release/1.4.0
e02e57d 
Release 1.4.0 into develop
@mokagio
Relax Rake version requirement to > 12.3, < 14.0 (#295)
07b3152 
This should make the library more friendly to clients as we migrate everyone to Rake 13
@AliSoftware
Update get_version_from_properties & update_versions methods with new…
8283eaf 
… key conventions
@AliSoftware
Remove product_name parameter from private get_version_from_propertie…
b0d30a2 
…s method
@AliSoftware
Add deprecations notices for the app: param in helpers
434db55 
We're not yet removing it completely because it would require also updating the actions, and thus also updating the ConfigItems of those actions and create a breaking change. We will get there very soon, but let's do it one step at a time.
@AliSoftware
Remove requirement about updateVersionProperties gradle task in actio…
6196c08 
…ns' descriptions
@AliSoftware
Tests: Prevent rspec from emitting git warning messages about default…
4b5158e 
… branch naming
@AliSoftware
Fix rubocop offenses
cc99872
@AliSoftware
Add unit tests for update_versions
0acb3a9
@AliSoftware
Fix tests for when running in a machine with an older version of git
0b7a78a
@AliSoftware
Add CHANGELOG entry
38507d4
@AliSoftware
Improve doc wording
7d289b0
@AliSoftware
Merge pull request #298 from wordpress-mobile/jetpack-infra/step1
908ff74 
Update Android versioning helpers to use unified versions for JP/WP
@mokagio
Add failing test to reproduce the new line bug in the generated .pot
e74a71b
@mokagio
Strip trailing new line when generating .pot for "standard" block
051b0b1
@mokagio
Use StringIO to write POT in spec to bypass the filesystem
28dba6d 
Hat tip @AliSoftware.
See #297 (comment)
@mokagio
Replace a strip call with a more appropriate rstrip
f7ecdfd 
Thank you for the suggestion @AliSoftware.

See #297 (comment)
@mokagio
Add test for multi-line string POT block generation
27a1c74
@mokagio
Add spec/an_metadata_update_helper_spec.rb to .rubocop_todo.yml
b3b1628 
As suggested here,
#297 (comment),
to avoid Danger warnings that we are not in a position to address
right away.
@mokagio
Replace a %q() with squiggly heredoc with disabled interpolation
cb94546 
Hat tip @AliSoftware.

See:

- #297 (comment)
- https://rubyreferences.github.io/rubyref/language/literals.html#here-documents-heredocs
@mokagio
Strip trailing new lines in single-line msgid in .po[t] (#297)
603e6f6
@AliSoftware
Remove all the app: parameters
fe82b21
@AliSoftware
Fix git failures in rspecs
b3d5a36 
When run with a modern git version which supports `--initial-branch`, git init was run twice due to using `|` instead of expected `||` in the shell commands
@oguzkocer
Adds a changelog for strip trailing newline bug fix
d9e629a
@oguzkocer @AliSoftware
Add PR number to the "strip trailing new lines" changelog
97dd7d8 
Co-authored-by: Olivier Halligon <[email protected]>
@oguzkocer
Merge pull request #301 from wordpress-mobile/add-changelog-for-strip…
ff2576c 
…-trailing-newline-bug-fix

Adds a changelog for "strip trailing newline" bug fix
@AliSoftware @mokagio
Remove useless () in 0-arity method calls
583209c 
h/t @mokagio

Co-authored-by: Gio Lodi <[email protected]>
@AliSoftware
Revert useless addition of self. in call
c25108d
@AliSoftware
bundle update
439b661
@AliSoftware
Add CHANGELOG entry
3cbcdca
@AliSoftware AliSoftware added the Releases Release related stuff label Oct 19, 2021
@AliSoftware AliSoftware requested a review from a team October 19, 2021 14:49
@AliSoftware AliSoftware self-assigned this Oct 19, 2021
mokagio
mokagio approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@mokagio mokagio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

See also #303 (review) regarding the Buildkite "failures".

@AliSoftware AliSoftware merged commit 34b5e0f into trunk Oct 20, 2021
@AliSoftware AliSoftware deleted the release/2.0.0 branch October 20, 2021 13:24
@AliSoftware
Copy link
Contributor Author

AliSoftware commented Oct 20, 2021 •
edited
Loading

I had to release the gem (gem push) manually, by restarting the CircleCI job with SSH then connecting to the image with SSH and re-running the commands from the gem-push job manually, after installing the brewfile.

This is because the job is currently configure to skip the brew install during gem-push, while we need those brew formulae to be installed so we can gem build and gem install the gem before gem push. So the compilation failed during installation of rmagick due to pkg-config not being installed.
I am not sure why we configured the gem-push job to skip brew install back then and how it has been working in the past.

We'll have to fix this at some point, likely during the migration to BuildKite – See #299 (comment) for additional details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mokagio mokagio mokagio approved these changes

Assignees

@AliSoftware AliSoftware

Labels
Releases Release related stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AliSoftware @mokagio @oguzkocer