Adds a changelog for "strip trailing newline" bug fix #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
approved these changes
Oct 6, 2021
Co-authored-by: Olivier Halligon <[email protected]>
|
I assume someone started to add Buildkite to this repo, but I don't see a .buildkite folder yet, so I am going to proceed with merging this. |
|
Yup, @jkmassel have a PR opened to add BuildKite but not merged yet hence why no |
|
Oh, I see how it is. He realized I have no contribution to this project, so didn't add me as a reviewer 😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was planning to do a minor release and realized there wasn't a changelog for #297, so I added the title of that PR to the Bug fixes section. I am no longer planning to do the release, but I think it's still good to have that in the changelog.
P.S: It turns out this is my first PR in this project 😱