Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade compile and target sdk version to Android API 31 #20

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Upgrade compile and target sdk version to Android API 31 #20

merged 5 commits into from
Oct 13, 2022

Conversation

fluiddot
Copy link

@fluiddot fluiddot commented Oct 4, 2022 •
edited
Loading

Description

This PR is related to the upgrade effort to Android 12 in Gutenberg Mobile: wordpress-mobile/gutenberg-mobile#5181. It basically updates all references of compileSdkVersion and targetSdkVersion parameters to use version 31.

Test plan

This update can be tested using the Gutenberg editor and the following PR: WordPress/gutenberg#44610.
The idea would be to run smoke testing on the demo project in order to check that there are no issues with Android 12.

@fluiddot fluiddot self-assigned this Oct 4, 2022
@fluiddot fluiddot mentioned this pull request Oct 4, 2022
Merged
@fluiddot fluiddot marked this pull request as ready for review October 4, 2022 16:55
@fluiddot fluiddot mentioned this pull request Oct 5, 2022
Closed
@jhnstn jhnstn self-requested a review October 5, 2022 13:35
jhnstn
jhnstn approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via WordPress/gutenberg#44610

@fluiddot fluiddot changed the base branch from wp-fork to wp-fork-5.2.0-wp-2 October 13, 2022 11:25
@fluiddot
Copy link
Author

Version 5.2.0-wp-3 has been already released with the changes required for the RN upgrade to 0.69. However, the reference to this package hasn't been updated yet in Gutenberg, hence this change will be released as wp-4 and then incorporated into wp-fork branch, leading to a new version wp-5 that will contain all recent changes (i.e. wp-3 + wp-4).

@fluiddot fluiddot changed the base branch from wp-fork-5.2.0-wp-2 to wp-fork October 13, 2022 11:32
@fluiddot fluiddot merged commit 1c90dff into wp-fork Oct 13, 2022
This was referenced May 18, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhnstn jhnstn jhnstn approved these changes

Assignees

@fluiddot fluiddot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @jhnstn