Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile and target Android API 31 #5181

Closed
AjeshRPai opened this issue Sep 29, 2022 · 3 comments · Fixed by #5184
Closed

Compile and target Android API 31 #5181

AjeshRPai opened this issue Sep 29, 2022 · 3 comments · Fixed by #5184
Assignees
Labels
[Pri] High [Type] Enhancement Improves a current area of the editor

Comments

@AjeshRPai
Copy link

AjeshRPai commented Sep 29, 2022

Parent #wordpress-mobile/WordPress-Android#16062

As part of the migration of WP Android to Android 12, the targetSdkVersion on the dependent libraries can be updated to 31. The Wordpress Android had a targetSdkVersion of 30 which now has been updated to 31 in this PR - wordpress-mobile/WordPress-Android#17153. So in order to keep the targetSdkVersion to be consistent with the apps, this change needs to be taken up.

UPDATE: The following Android dependencies need also to be updated to Android 12:

Dependencies from forked repositories (published to JitPack)

Dependencies from NPM packages (published to S3 via react-native-libraries-publisher)

UPDATE: The following libraries are external so we won't be updating them for now.

  • react-native-get-random-values
  • react-native-reanimate
  • react-native-safe-area-context
  • react-native-screen
  • react-native-svg
  • react-native-webview
  • react-native-masked-view
  • react-native-clipboard
  • react-native-gesture-handler
  • react-native-fast-image
@AjeshRPai AjeshRPai added the [Type] Enhancement Improves a current area of the editor label Sep 29, 2022
@AjeshRPai AjeshRPai self-assigned this Sep 29, 2022
@AjeshRPai AjeshRPai changed the title [RNMobile] Compile and target Android API 31 Compile and target Android API 31 Sep 29, 2022
@fluiddot
Copy link
Contributor

Setting this task as a high priority as we should include it in the next WP-Android release 21.0.

Internal reference: p1664442201957959-slack-C6UJ0KRKQ

@fluiddot
Copy link
Contributor

fluiddot commented Sep 30, 2022

I noticed that some of the forked repositories we have in Gutenberg, which are Android dependencies to the project, have targetSdkVersion set to 30:

I understand that we'd need to update them too as we're doing with other libraries, @AjeshRPai wdyt?

@AjeshRPai
Copy link
Author

AjeshRPai commented Sep 30, 2022

@fluiddot Thanks for the ping and noticing the targetSdkVersion on the other libraries. 🙇🏼

I understand that we'd need to update them too as we're doing with other libraries, @AjeshRPai wdyt?

Yup, we'd need to update them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] High [Type] Enhancement Improves a current area of the editor
Projects
None yet
2 participants