Feature/lists

[SergioEstevao]

Refs #208
Gutenberg PR WordPress/gutenberg#14249
New Gutenberg PR WordPress/gutenberg#14636

This PR implements the list block by only changing components and not touching the code of the original web block.

This achieved by improving the implementation of the block-edit context in order to send the isSelected and onFocus props to the RichText components.

For the moment it doesn't implement the indent and outdent buttons, because of a bug in Aztec for iOS that doesn't allow split to work properly when lists are indented.

If testing on iOS please run yarn preios to make sure you get the right version of Aztec.

How to test:

• Start the demo app
• Check the list display properly and you can interact with them and change type
• Add new list block to the post
• Check that the list block works properly.

[hotchemi]

Ignore me if it is out of the point 🙇

[SergioEstevao]

Here is update of the current status of this PR:

• Insertion of a new list block
• Display of list block already present in the content
• Ability to write inside the lists
• Convert a block list from ordered ol to unordered 'ul' using the toolbar
• Indent in is working
• Indent out is not working
• When splitting the block an extra paragraph block is being inserted on the middle of the split.

All the above are working on iOS, but on Android we have some issues:

• Changing from bullets to number list is not working on Android, this is done on JS code so it's strange for me why is not working.
• Aztec android needs to implement the isMultiline prop added to the component. When this boolean parameter is on onEnter prop should only be invoked when an Enter is pressed and the previous line is an empty line.

@koke do you think after the Android issues we should merge this with a feature flag in place?

@hypest do you want to tackle the Android issue?

[hypest]

As far as I can see on Android, adding a new item to the list by tapping Enter at the end of an item is broken. Instead of adding a new bullet, the block is actually split. Haven't debugged this yet but, @SergioEstevao are you referring to that too when you say Aztec android needs to implement the isMultiline prop added to the component. When this boolean parameter is on onEnter prop should only be invoked when an Enter is pressed and the previous line is an empty line.?

@hypest do you want to tackle the Android issue?

Yeap, added it to my plans for this sprint 👍

[SergioEstevao]

Yes it's exactly that! When the multiline property is true pressing Enter shouldn't send an onEnter event up that causes the split.

…

On Thu, 28 Mar 2019 at 09:01, Stefanos Togoulidis ***@***.***> wrote: As far as I can see on Android, adding a new item to the list by tapping Enter at the end of an item is broken. Instead of adding a new bullet, the block is actually split. Haven't debugged this yet but, @SergioEstevao <https://github.com/SergioEstevao> are you referring to that too when you say Aztec android needs to implement the isMultiline prop added to the component. When this boolean parameter is on onEnter prop should only be invoked when an Enter is pressed and the previous line is an empty line.? @hypest <https://github.com/hypest> do you want to tackle the Android issue? Yeap, added it to my plans for this sprint 👍 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#704 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAnxUQb1OFt3v-qSUfoIvCg_Y7mSo8jTks5vbITBgaJpZM4bfoQN> .

[SergioEstevao]

@Tug do you mind to test this. If testing on iOS please run yarn preios to make sure you get the right version of Aztec.

[Tug]

withSelect only add new props to the component, so it should not be necessary to explicitly add clientId which is already a prop given from the parent component here.

[Tug]

Nice work, we now have List ✋🎉🎈!!

Tested on both Android and iOS and it worked smoothly

[peril-wordpress-mobile]

	Warnings
⚠️	PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS