-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates GB version to support list blocks #11409
Conversation
# Conflicts: # Podfile # Podfile.lock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @SergioEstevao - Lists are working great! 🎉
I have one question:
When splitting the list block, I get a paragraph block in the middle. Also, when splitting an ordered list, the second half is converted into an unordered list. I'm not sure if that's expected or a known issue.
If it is, let's
If it's not, I guess we can create a new tickets and 😁
@etoledom both your findings also happen on the web version, so I assume that is by design :). Thanks for the review! |
The ordered-list-becomes-unordered-on-split feels like a bug. @ellatrix maybe you have some clue on this one? |
What's not expected about this? What do you expect?
@hypest @SergioEstevao I don't see this happening for web. |
My first expectation was to have just two list blocks, as when splitting a paragraph block. But on a second thought, it makes total sense. If I split a list, it would most probably be to write something in between. 👍 |
@etoledom It's the same in most editors I've come across. :) |
I just tested in WP.com and saw this happening: Create a list block |
Here's what I see on the web (Frontenberg) at the time of writing @ellatrix when I hit "Enter" two times in a middle list item: The second half of the ordered list becomes unordered. Not sure if Frontenberg has the latest of Gutenberg or this behavior is by design. |
@hypest Ah, I was on a different branch. Looks like WordPress/gutenberg#14840 fixes it. |
@hypest Added a test: WordPress/gutenberg@1aec480 Would appreciate a review of the PR. :) |
Fixes wordpress-mobile/gutenberg-mobile#208
Related GB-mobile PR: wordpress-mobile/gutenberg-mobile#704
To test:
Update release notes:
RELEASE-NOTES.txt
.