fix: Prevent crash from invalid media URLs

[wpmobilebot]

Related PRs

• fix: Prevent crash from invalid media URLs WordPress/gutenberg#54834 by @dcalhoun

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

[fluiddot]

Approved via WordPress/gutenberg#54834.

@dcalhoun it would be great to include this change in the release notes. I understand the solved crash is a regression introduced in 1.104.0 via WordPress/gutenberg#54096, is this accurate? If so, we should consider incorporating the fix as a beta fix into WP-iOS version 23.3. WDYT?

[dcalhoun]

@dcalhoun it would be great to include this change in the release notes.

I was relying upon the expectation that the release process would grab the change log entry. I will proactively add a release note in this PR.

I understand the solved crash is a regression introduced in 1.104.0 via WordPress/gutenberg#54096, is this accurate? If so, we should consider incorporating the fix as a beta fix into WP-iOS version 23.3. WDYT?

No, this crash is actually reproducible as far back as the 22.7 release, which is the oldest available in TestFlight. This appears to be a long-standing crash.

Given it is a long-standing crash, the urgency feels lower. However, one could argue the error prone nature of typing on mobile device keyboards is prone to errors and thus we should prioritize addressing this. That said, I wonder how often someone types a long URL as opposed to pasting it. The latter could still produce an invalid URL, but less likely.

WDYT?

[fluiddot]

I was relying upon the expectation that the release process would grab the change log entry. I will proactively add a release note in this PR.

Ah, I thought we updated the release notes per PR. The release process implies updating the release notes, but AFIK we only replace the Unreleased section with the version being cut.

No, this crash is actually reproducible as far back as the 22.7 release, which is the oldest available in TestFlight. This appears to be a long-standing crash.

@dcalhoun Oh, sorry for the confusion. I thought that this was related to the recent changes introduced in WordPress/gutenberg#54096. If this can be reproduced in older versions, I agree the urgency of providing a crash fix in the current release is lower than I originally thought.

Given it is a long-standing crash, the urgency feels lower. However, one could argue the error prone nature of typing on mobile device keyboards is prone to errors and thus we should prioritize addressing this. That said, I wonder how often someone types a long URL as opposed to pasting it. The latter could still produce an invalid URL, but less likely.

WDYT?

I agree, the main reason for considering this a beta fix was merely the fact of addressing a regression. I checked the Sentry event related to the crash and only impacted three users, so I think it doesn't have a severity/impact to consider it as a beta fix to incorporate into 23.3.

[dcalhoun]

I was relying upon the expectation that the release process would grab the change log entry. I will proactively add a release note in this PR.

Ah, I thought we updated the release notes per PR. The release process implies updating the release notes, but AFIK we only replace the Unreleased section with the version being cut.

You are correct. My action (or inaction) was a cryptic, un-communicated change in my behavior relating to Git flow and release processes discussions (p9ugOq-3yd-p2#comment-6868) that have not yet been affirmed across the wider team. It was ill-advised on my part. The team should fully aware and committed prior to altering process. Sorry about that.