fix: Prevent crash from invalid media URLs #54834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcalhoun
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.62 MB ℹ️ View Unchanged
|
dcalhoun
added
the
Mobile App - Automation
|
Flaky tests detected in a3e958f6cf1f56fb1c60aa8050bc805711963dca. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/6316142778
|
dcalhoun
force-pushed
the
fix/prevent-crash-from-invalid-media-urls
branch
from
ca09707
to
1907faf
Compare
The `isURL` utility considers URLs using uncommon protocols to be valid, as constructing `URL` with, say, `h://a-path.com` is valid. Contrastingly, the `react-native-video` package only considers a URL using the `http:` or `https:` protocols to be a "network" asset. This leads to an attempt to load the URL as a local asset, which fails as the asset does not exist in the app bundle. https://github.com/react-native-video/react-native-video/blob/81ae785090f5ce3d5e45cc51f68a3360a85be853/Video.js#L277
dcalhoun
force-pushed
the
fix/prevent-crash-from-invalid-media-urls
branch
from
1907faf
to
0a540b8
Compare
fluiddot
approved these changes
Sep 27, 2023
Correct, I should've noted that. Thank you for calling this out.
|
4 tasks
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Prevent crashes resulting from attempts to set an invalid URL for a video or
audio file, e.g.
h://domain.org/video.mp4.Why?
Fixes wordpress-mobile/gutenberg-mobile#6233. The crash is disruptive for users.
How?
Detect and avoid sending URLs that do not begin with
http:orhttp://to thereact-native-videopackage as it will attempt and fail to load the URL as alocal app bundle resource. Instead, display a notice to the user that the
provided URL is invalid.
The
isURLutility considers URLs using uncommon protocols to be valid,as constructing
URLwith, say,h://a-path.comis valid.Contrastingly, the
react-native-videopackage only considers a URLusing the
http:orhttps:protocols to be a "network" asset. Thisleads to an attempt to load the URL as a local asset, which fails as the
asset does not exist in the app bundle.
Testing Instructions
h://wordpress.org/video.mp4.Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a