Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.91.0 #5564

Merged
merged 10 commits into from
Mar 17, 2023
Merged

Release 1.91.0 #5564

merged 10 commits into from
Mar 17, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Mar 16, 2023 •
edited
Loading

Release for Gutenberg Mobile 1.91.0

Related PRs

Extra PRs that Landed After the Release Was Cut

PR 1

Changes

Change 1

Fixes the fact that Paragraph blocks couldn't be transformed into the Quote block. The fix also allows more block transforms for other blocks, including the ability for most blocks to transform to the Group or Columns block and the option for most text-based blocks to transform to the Quote block.

Test plan

Once the installable builds of the main apps are ready, perform a quick smoke test of the editor on both iOS and Android to verify it launches without crashing. We will perform additional testing after the main apps cut their releases.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

This was referenced Mar 16, 2023
Merged
Merged
Merged
@SiobhyB SiobhyB marked this pull request as ready for review March 16, 2023 12:18
fluiddot
fluiddot reviewed Mar 16, 2023
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the E2E tests jobs don't start 🤔 . Since they depend on other jobs that seem that failed on the first run, I'm wondering if that's the culprit for having them pending.

Screenshot 2023-03-16 at 15 22 45

@SiobhyB maybe we could try to re-run the entire workflow and see if that helps.

RELEASE-NOTES.txt Show resolved Hide resolved
fluiddot
fluiddot approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All jobs are ✅ so we can consider this PR ready to merge 🎊 .

@SiobhyB SiobhyB merged commit d1d12e8 into trunk Mar 17, 2023
@SiobhyB SiobhyB deleted the release/1.91.0 branch March 17, 2023 16:42
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Mar 21, 2023 •
edited
Loading

🟢 Included Changes (Android)

Build: 22.0-rc-1
Device: Pixel 6 (Android 13)

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Mar 21, 2023 •
edited
Loading

🟢 Writing Flow (Android)

Build: 22.0-rc-1
Device: Pixel 6 (Android 13)

General

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Mar 21, 2023 •
edited
Loading

🟢 Test Suite 1 (Android)

Build: 22.0-rc-1
Device: Pixel 6 (Android 13)

Gallery - 1

  • Gallery block - Close/Re-open post with an ongoing image upload - TC001
  • Gallery block - Close post with an ongoing image upload - TC002

Gallery - 2

  • Gallery block - Insert image from device (failing) - TC006
  • Gallery block - Insert image from device (cancel) - TC009

Gallery - 3

  • Gallery block - Add Gallery Caption - TC003
  • Gallery block - Add Gallery Image Caption - TC04
  • Gallery block - Try adding same images from WP Media library and moving the images around - TC010

Columns - 1

  • Columns - Multiple slider in columns parent - TC011
  • Columns - Check if Column placeholders is visible for the unselected state - TC001
  • Columns - Appearance in vertical device position (vertical layout) - TC004

Columns - 2

  • Columns - Max limit of Column number - TC002
  • Columns - Deep nesting is possible (iOS only)- TC003
  • Columns - Appearance in horizontal device position (horizontal layout) - TC005

Columns - 3

  • Columns - Mover direction - TC006
  • Columns - Check if Column placeholder is render in nested structure - TC007
  • Columns - Unselected Column placeholder is stretched to content in nested structure- TC008

MediaText - 1

  • Media Text block - Insert image from device (failing) - TC001
  • Media Text block - Close/Re-open post with an ongoing image upload - TC003

MediaText - 2

  • Media Text block - Insert video from device - TC002-v
  • Media Text block - Insert image from device - TC002-i

MultipleUpload - 1

  • Simultaneous uploads - TC001

Cover - 1

  • Cover - Add image background from WordPress Media library - TC001
  • Cover - Image focal point is rendered properly - TC002
  • Cover - Custom color is rendered properly - TC002

Editor Theme - 1

  • Default Colors - Check that default colors still load - TC001
  • Default Gradients - Check that default gradients still load - TC002
  • Custom Colors - Check that custom colors load in the editor - TC003

Social Icons - 1

  • Active icon gets product color - TC001
  • Social icon forwarding to the link - TC002

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Mar 21, 2023 •
edited
Loading

🟢 Unsupported Block Tests (Android)

Build: 22.0-rc-1
Device: Pixel 6 (Android 13)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@geriux
Copy link
Contributor

geriux commented Mar 21, 2023 •
edited
Loading

🟢 Writing Flow checklist (iOS)

Build: 22.0.0.0 (From Testflight)
Device: iPhone 14 Pro (OS 16.3.1)

General

  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
    • Quote block
    • Verse block
    • Preformatted block
    • Code block (DEV only)
    • Pullquote block

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC001 - Highlight selected text
  • TC001 - Highlight text without selection
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • TC009 - Test autocorrection doesn't apply formatting to Heading
  • TC010 - Test autocorrection doesn't remove formatting from Heading
Splitting and merging
  • TC001 - Merge after writing
    • Paragraph
    • Heading
  • TC002 - Merge after selection
    • Paragraph
    • Heading
  • TC003 - Merge after deleting text
    • Paragraph
    • Heading
  • TC004 - Merge after deleting all
    • Paragraph
    • Heading
  • TC005 - Merge multiple blocks
    • Paragraph
    • Heading
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

@geriux
Copy link
Contributor

geriux commented Mar 21, 2023 •
edited
Loading

🟢 Test Suite 2 (iOS)

Build: 22.0.0.0 (From Testflight)
Device: iPhone 14 Pro (OS 16.3.1)

DarkMode - 1

  • Gallery block - Dark mode - TC001
  • Shortcode block - Dark mode - TC002
  • Media Text block - Dark mode - TC003

Group - 1

  • Group - Deep nesting is possible (verify iOS does not crash) - TC001
  • Group - Check if Group placeholder is visible for the unselected state - TC002
  • Group - Check if Group placeholder is render in nested structure - TC003
  • Group - Nested block have proper border styling - TC004
  • Group - Breadcrumbs on FloatingToolbar is properly displayed - TC005

Buttons-1

  • Buttons block - Button's wrapper grows properly - TC019
  • Buttons block - Removing exactly one Button (when Buttons contain more of them) - TC002
  • Buttons block - Wrapping Buttons - TC003

Button-2

  • Buttons block - Buttons alignment options - TC004
  • Buttons block - Settings: Open in new tab - TC007
  • Buttons block - Settings: Link rel - TC008

Button-3

  • Buttons block - Settings: Link URL - TC006
  • Buttons block - Settings: Remove link - TC010
  • Buttons block - Settings: Synchronize with button options - TC009

Color Settings - 1

  • Colors Segmented Controls - TC001
  • Scroll color palette to start - TC002
  • Scroll color palette to the end - TC003

Image - 1

Drag and Drop Blocks - 1

  • Drag and Drop Blocks - Drag block to the top of the content - TC001
  • Drag and Drop Blocks - Drag block to the bottom of the content - TC002

@geriux
Copy link
Contributor

geriux commented Mar 21, 2023 •
edited
Loading

🟢 Unsupported Block Editing (iOS)

Build: 22.0.0.0 (From Testflight)
Device: iPhone 14 Pro (OS 16.3.1)

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@geriux
Copy link
Contributor

geriux commented Mar 21, 2023 •
edited
Loading

🟢 New changes (iOS)

Build: 22.0.0.0 (From Testflight)
Device: iPhone 14 Pro (OS 16.3.1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SiobhyB @geriux @fluiddot