-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate gutenberg-mobile release 1.91.0 #20340
Conversation
Generated by 🚫 dangerJS |
📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
As on previous GB-mobile releases, before merging this PR we need to wait for the Gutenberg Mobile release PR to be merged first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I've just noticed that the UI tests are failing and the errors are related to the editor:
WordPressUITests.EditorGutenbergTests
--
| testAddGalleryBlock, failed: caught error: "timedOut"
| <unknown>:0
|
| testAddGalleryBlock, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testAddGalleryBlock, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testAddRemoveFeaturedImage, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testAddRemoveFeaturedImage, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testAddRemoveFeaturedImage, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testBasicPostPublishWithCategoryAndTag, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testBasicPostPublishWithCategoryAndTag, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testBasicPostPublishWithCategoryAndTag, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testTextPostPublish, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testTextPostPublish, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
| testTextPostPublish, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
| /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
|
|
| Executed 19 tests, with 1 test skipped and 12 failures (1 unexpected) in 1587.713 (1587.730) seconds
The test failures appear to be caused by the text input having no value:
The UI test input value has 0 words and 0 characters, and is being compared to the assertion with 5 word and 24 characters. This may be related to an issue with iOS dictation where the text input doesn't "finish" processing the value of the user's input until the input is blurred. This is known and discussed further on this thread: |
Description
This PR incorporates the 1.91.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#5564
Release Submission Checklist
RELEASE-NOTES.txt
if necessary.