Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate gutenberg-mobile release 1.91.0 #20340

Merged
merged 8 commits into from
Mar 17, 2023

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Mar 16, 2023

Description

This PR incorporates the 1.91.0 release of gutenberg-mobile.
For more information about this release and testing instructions, please see the related Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#5564

Release Submission Checklist

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SiobhyB SiobhyB added the Gutenberg Editing and display of Gutenberg blocks. label Mar 16, 2023
@SiobhyB SiobhyB added this to the 22.0 milestone Mar 16, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 16, 2023

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 16, 2023

Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr20340-339948e
Version21.9
Bundle IDcom.jetpack.alpha
Commit339948e
App Center Buildjetpack-installable-builds #4281
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 16, 2023

WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr20340-339948e
Version21.9
Bundle IDorg.wordpress.alpha
Commit339948e
App Center BuildWPiOS - One-Offs #5257
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@SiobhyB SiobhyB marked this pull request as ready for review March 16, 2023 12:20
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

As on previous GB-mobile releases, before merging this PR we need to wait for the Gutenberg Mobile release PR to be merged first.

Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I've just noticed that the UI tests are failing and the errors are related to the editor:



WordPressUITests.EditorGutenbergTests
--
  | testAddGalleryBlock, failed: caught error: "timedOut"
  | <unknown>:0
  |  
  | testAddGalleryBlock, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testAddGalleryBlock, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testAddRemoveFeaturedImage, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testAddRemoveFeaturedImage, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testAddRemoveFeaturedImage, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testBasicPostPublishWithCategoryAndTag, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testBasicPostPublishWithCategoryAndTag, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testBasicPostPublishWithCategoryAndTag, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 2, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testTextPostPublish, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testTextPostPublish, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  | testTextPostPublish, XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.
  | /usr/local/var/buildkite-agent/builds/MV-MKE-X64-010/automattic/wordpress-ios/WordPress/UITestsFoundation/Screens/Editor/BlockEditorScreen.swift:181
  |  
  |  
  | Executed 19 tests, with 1 test skipped and 12 failures (1 unexpected) in 1587.713 (1587.730) seconds

@derekblank
Copy link
Contributor

The test failures appear to be caused by the text input having no value:

XCTAssertEqual failed: ("Content Structure Blocks: 1, Words: 0, Characters: 0") is not equal to ("Content Structure Blocks: 1, Words: 5, Characters: 24") - Unexpected post structure.

The UI test input value has 0 words and 0 characters, and is being compared to the assertion with 5 word and 24 characters. This may be related to an issue with iOS dictation where the text input doesn't "finish" processing the value of the user's input until the input is blurred. This is known and discussed further on this thread:

@SiobhyB SiobhyB merged commit e3d58aa into trunk Mar 17, 2023
@SiobhyB SiobhyB deleted the gutenberg/integrate_release_1.91.0 branch March 17, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants