test: Add Sanity Test Suite 1 #5548
Conversation
Verify layout spacing and alignment for portrait and landscape orientations.
Simplify test setup for subsequent tests.
The animated closure of the modal caused discrepancies in image snapshots.
dcalhoun
added
[Type] Enhancement
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
👋🏻 @geriux. I refrained from creating new helpers so far, as I wanted to avoid abstracing prematurely. That said, I am open to any you believe are worthwhile. I'll likely re-review the tests myself seeking low-level abstractions that may make sense, but wanted to request your review now regardless. Let me know what you think. Thanks! |
Co-authored-by: Gerardo Pacheco <[email protected]>
The available elements within this context are unexpected, with certain elements unavailable or covered by non-visual elements, e.g. resize observer. I consider this change a workaround. There is likely a better way of achieving this, possibly an existing helper that could be used or modified to support this context.
Increase the stability and adaptability of the slider interaction logic.
Fix inconsistent test results on Android caused by minute differences in final scroll position.
Detect minute differences in column preview widths.
…into test/add-sanity-test-suite-1
|
@geriux this PR and the related PR are both ready for another review. Thanks! |
There was a problem hiding this comment.
LGTM! I left one comment related to the name of the test but overall looks good to me! Thank you for making the changes, so exciting to have more tests being added! ❤️
I also approved the Gutenberg PR via WordPress/gutenberg#48978 (review)
Co-authored-by: Gerardo Pacheco <[email protected]>
…into test/add-sanity-test-suite-1
Related PRs
Description
To test: n/a
PR submission checklist: