test: Expand mobile e2e test helpers #48978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Block buttons that happen to be rendered behind the virtual home button could not be clicked, even though they were technically visible. This adds a method to evaluate whether an element is within a given bounds.
dcalhoun
added
[Type] Enhancement
2 tasks
|
Size Change: 0 B Total Size: 1.34 MB ℹ️ View Unchanged
|
The previous command requires rebooting the device to take effect. The new commands updates the appearance immediately.
This will avoid repeating logic to find a block type button within the insterter, and is a common practice for nested blocks.
The test that relied upon this functionality, adding a block before the currently selected block, is now an integration test.
…nd-mobile-e2e-test-helpers
|
Flaky tests detected in 0d11b28. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4451455041
|
geriux
reviewed
Mar 24, 2023
geriux
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs
What?
Expand the mobile e2e test helpers for account for new test coverage.
Why?
button on mobile devices.
How?
Testing Instructions
n/a
Testing Instructions for Keyboard
n/a
Screenshots or screencast
n/a