Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use android artifacts for react-native libraries in react-native-bridge #4636

Conversation

wpmobilebot
Copy link
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 8, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot self-requested a review March 11, 2022 10:47
@fluiddot fluiddot added this to the 1.72.0 milestone Mar 11, 2022
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#39294 (review).

NOTE: Before merging this PR we should update the Gutenberg reference with the merge commit of WordPress/gutenberg#39294.

@wpmobilebot wpmobilebot deleted the version-toolkit/gutenberg/use-android-artifact-for-react-native-libraries branch March 15, 2022 04:12
@fluiddot fluiddot restored the version-toolkit/gutenberg/use-android-artifact-for-react-native-libraries branch March 15, 2022 08:37
@fluiddot fluiddot reopened this Mar 15, 2022
@fluiddot
Copy link
Contributor

It would be great to include the changes from WordPress/gutenberg#39294 in GB-mobile, for this reason, I re-opened the PR and I'm planning to merge it once the conflicts are solved.

@wpmobilebot wpmobilebot deleted the version-toolkit/gutenberg/use-android-artifact-for-react-native-libraries branch March 15, 2022 08:42
@fluiddot fluiddot restored the version-toolkit/gutenberg/use-android-artifact-for-react-native-libraries branch March 15, 2022 08:43
@fluiddot fluiddot reopened this Mar 15, 2022
@fluiddot fluiddot merged commit 20260bd into trunk Mar 15, 2022
@fluiddot fluiddot deleted the version-toolkit/gutenberg/use-android-artifact-for-react-native-libraries branch March 15, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants