Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/3800 unitcontrol label color #3836

Closed
wants to merge 3 commits into from

Conversation

AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented Aug 12, 2021

Fixes: ##3800
Gutenberg PR: WordPress/gutenberg#34057

To test

Follow the test instructions in the Gutenberg PR: WordPress/gutenberg#34057

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@AmandaRiu AmandaRiu requested a review from guarani August 12, 2021 22:47
@AmandaRiu AmandaRiu added this to the 1.58.3 (17.9.1) milestone Aug 12, 2021
@fluiddot
Copy link
Contributor

@AmandaRiu I see that this PR was assigned to 1.58.3 milestone but that was created for a hotfix, if you're aiming to include this in the next release we would need to create the 1.60.1 milestone.

@fluiddot fluiddot removed this from the 1.58.3 (17.9.1) milestone Aug 17, 2021
@AmandaRiu AmandaRiu added this to the 1.60.0 (18.1) milestone Aug 17, 2021
@AmandaRiu
Copy link
Contributor Author

@AmandaRiu I see that this PR was assigned to 1.58.3 milestone but that was created for a hotfix, if you're aiming to include this in the next release we would need to create the 1.60.1 milestone.

Thanks @fluiddot , yup, I meant this for the next release. I've moved it.

@geriux
Copy link
Contributor

geriux commented Aug 19, 2021

Hey @AmandaRiu. We will cut the 1.60.0 release today. I will bump this PR to the next milestone, but please let me know if you’d rather us work to include this PR in 1.60.0. Thanks!

@geriux geriux modified the milestones: 1.60.0 (18.1), 1.61.0 (18.2) Aug 19, 2021
@mkevins
Copy link
Contributor

mkevins commented Sep 2, 2021

Hey @AmandaRiu. 👋 😄 We will cut the 1.61.0 release today. I will bump this PR to the next milestone, but please let me know if you’d rather us work to include this PR in 1.61.0. Thanks!

Edit: There is a chance the release cut will be delayed until tomorrow. Since this PR is still awaiting the ✔️ , I've bumped the milestone - but let me know if you'd like to get it into 1.61.0. 👍

@mkevins mkevins modified the milestones: 1.61.0 (18.2), 1.62.0 Sep 2, 2021
@guarani
Copy link
Contributor

guarani commented Sep 2, 2021

Thanks @mkevins! I'll be taking over this PR.
Bumping the milestone is fine I think 👍

@jd-alexander
Copy link
Contributor

Hey @AmandaRiu .We will cut the 1.62.0 release today so I am bumping this PR to the next milestone. Let me know if you’d rather us work to include this PR in 1.62.0. Thanks!

@guarani guarani removed this from the 1.63.0 (18.4) milestone Sep 17, 2021
@guarani
Copy link
Contributor

guarani commented Sep 17, 2021

Thanks @jd-alexander!
I've taken over this PR and for now I'm going to remove the milestone now though, and re-add it once it's ready.
I'd hoped to get to it sooner 😞.

@jd-alexander
Copy link
Contributor

Thanks @jd-alexander!
I've taken over this PR and for now I'm going to remove the milestone now though, and re-add it once it's ready.
I'd hoped to get to it sooner 😞.

No problem @guarani Thanks for the update!

@guarani
Copy link
Contributor

guarani commented Mar 28, 2022

👋 I wasn't able to get to this unfortunately, I'd meant to take over as PR author. Apologies for the long delay.
I'll un-assign myself as reviewer and leave this open for someone else to get to if needed.
cc @hypest

@guarani guarani removed their request for review March 28, 2022 13:20
@AmandaRiu
Copy link
Contributor Author

Wow, this has been open for a very long time and the linked PR was already closed two years ago due to being stale. I'm going to go ahead and close this one. It can be reopened in the future if needed.

@AmandaRiu AmandaRiu closed this Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants