Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change style of unit label on UnitControl to the standard label color when UnitControl only has a single unit type #3800

Open
iamthomasbishop opened this issue Aug 5, 2021 · 2 comments
Labels
[Type] Bug Something isn't working

Comments

@iamthomasbishop
Copy link
Contributor

A recent PR on the web side fixed an issue with the native-mobile UnitControl component. The fix necessarily disables interactions with the unit part of the control, but the text label still maintains its active link/button style.

To avoid potential confusion, let's change the label color of the unit part of UnitControl to the standard cell label color—specifically in cases where UnitControl only has a single unit type.

To Reproduce
Steps to reproduce the behavior:

  1. Add Columns block
  2. Select an individual Column
  3. Open block settings by tapping on ⚙️ icon
  4. Note that the Width setting has a unit control with the active link/button style
@iamthomasbishop iamthomasbishop added the [Type] Bug Something isn't working label Aug 5, 2021
@hypest
Copy link
Contributor

hypest commented Aug 6, 2021

@AmandaRiu will try to get through this one as part of groundskeeping. cc @mchowning

@AmandaRiu
Copy link
Contributor

@AmandaRiu will try to get through this one as part of groundskeeping. cc @mchowning

I had spoken to Matt C. last week about this and said if I didn't get to it during groundskeeping, I'd would during this week - so I'll be working on it this week 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants