Fix: Native UnitControl to handle single unit config #33641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
7 tasks
|
Size Change: 0 B Total Size: 1.07 MB ℹ️ View Unchanged
|
Mamaduka
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
Thanks for the quick follow-up, @aaronrobertshaw.
Changes look good 👍
walbo
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #33634
Description
The UnitControl util function
hasUnitswas changed in #33634 to simply check that the passed units config wasn't empty or false.This changed its behaviour when the native UnitControl was relying on the previous behaviour where it checked there was more than 1 unit specified. The native UnitControl relied on this to avoid rendering a touchable button and picker when the user would have no alternative unit to select from.
This PR adds explicit checks for the length of units config into the native unit control.
How has this been tested?
Manually.
%Screenshots
Types of changes
Bug fix.
Checklist:
*.native.jsfiles for terms that need renaming or removal).