Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.58.2 #3795

Merged
merged 5 commits into from
Aug 4, 2021
Merged

Release 1.58.2 #3795

merged 5 commits into from
Aug 4, 2021

Conversation

SiobhyB
Copy link
Contributor

@SiobhyB SiobhyB commented Aug 4, 2021 •
edited by fluiddot
Loading

Release for Gutenberg Mobile 1.58.2

Related PRs

Extra PRs that Landed After the Release Was Cut

No extra PRs yet. 🎉

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.
  • Test the Unsupported Block Editor on WP Apps (see steps).
  • Sanity test suites for WP Apps should be completed for each platform.

Release Submission Checklist

  • Verify Items from test plan have been completed
  • Approve and run optional Android and iOS UI tests
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release. Replace Unreleased section with the release version and create a new Unreleased section.
  • Check if gutenberg/packages/react-native-editor/CHANGELOG.md is updated with all the changes that made it to the release. Replace ## Unreleased with the release version and create a new ## Unreleased.
  • Bundle package of the release is updated.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 4, 2021 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SiobhyB SiobhyB mentioned this pull request Aug 4, 2021
Merged
7 tasks
This was referenced Aug 4, 2021
Merged
Merged
@SiobhyB SiobhyB requested a review from fluiddot August 4, 2021 14:02
@SiobhyB SiobhyB marked this pull request as ready for review August 4, 2021 14:02
@SiobhyB
Copy link
Contributor Author

SiobhyB commented Aug 4, 2021 •
edited
Loading

🟢 Writing Flow Test Cases (iOS)

Tested with WPiOS 54239 on a iPhone XR (iOS 14.6).

General

  • TC001 - Block insertion
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Aug 4, 2021 •
edited
Loading

🟢 Unsupported Block Test Cases (iOS)

Tested with WPiOS build 54239 on iPhone XR (iOS 14.6).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • 🟡 [skipped due to a known issue] TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@SiobhyB
Copy link
Contributor Author

SiobhyB commented Aug 4, 2021 •
edited
Loading

🟢 Test the new changes (iOS)

Tested with WPiOS build 54239 on iPhone XR (iOS 14.6).

@fluiddot
Copy link
Contributor

fluiddot commented Aug 4, 2021 •
edited
Loading

🟢 Writing Flow Test Cases (Android)

Tested with WPAndroid 113571 on device Samsung Galaxy S20 FE 5G (Android 10).

General

  • TC001 - Block insertion
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components

Rich Text Format

  • TC001 - Bold, Italic, strikethrough buttons
  • TC002 - Alignment buttons
  • TC003 - Alignment Split
  • TC004 - Link button works without selection
  • TC005 - Link button works with a selected word
  • TC006 - Adding a link from a copied URL
  • TC007 - Test format detection under the cursor
  • TC008 - Test formatting doesn't remove leading or trailing whitespace
Splitting and merging
  • TC001 - Merge after writing
  • TC002 - Merge after selection
  • TC003 - Merge after deleting text
  • TC004 - Merge after deleting all
  • TC005 - Merge multiple blocks
  • TC006 - Splitting/merge list block

Undo / Redo - Test Cases

  • TC001 - Undo/redo block actions
  • TC002 - Undo/redo text
  • TC003 - Undo/redo text format

@fluiddot
Copy link
Contributor

fluiddot commented Aug 4, 2021 •
edited
Loading

🟢 Unsupported Block Test Cases (Android)

Tested with WPAndroid 113571 on device Samsung Galaxy S20 FE 5G (Android 10).

  • TC001 User can edit unsupported blocks on Simple WP.com sites
  • TC002 User can discard edits to an unsupported block on Simple WP.com sites
  • TC003 Editing unsupported blocks is allowed on Gutenberg-enabled Atomic sites
  • 🟡 [skipped due to a known issue] TC004 Editing unsupported blocks is disallowed on Classic-enabled Atomic sites
  • TC005 Editing unsupported blocks is enabled on self-hosted sites accessed via Jetpack
  • TC006 Editing unsupported blocks is disallowed on self-hosted sites access via their own username and password

@fluiddot
Copy link
Contributor

fluiddot commented Aug 4, 2021 •
edited
Loading

🟢 Test the new changes (Android)

Tested with WPAndroid 113571 on device Samsung Galaxy S20 FE 5G (Android 10).

@fluiddot
Copy link
Contributor

fluiddot commented Aug 4, 2021 •
edited
Loading

I noticed that the "Test iOS on Device" jobs didn't pass, looks like it failed with the common errors caused by flakiness so I've just restarted it.

fluiddot
fluiddot approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@fluiddot fluiddot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎊 !

NOTE: We should wait for the "Test iOS on Device" jobs to finish and pass before merging 🤞.

@fluiddot fluiddot added this to the 1.58.2 (17.9) milestone Aug 4, 2021
@SiobhyB SiobhyB merged commit 0eff5dc into trunk Aug 4, 2021
@SiobhyB SiobhyB deleted the release/1.58.2 branch August 4, 2021 17:09
@fluiddot fluiddot restored the release/1.58.2 branch August 12, 2021 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluiddot fluiddot fluiddot approved these changes

Assignees
No one assigned
Labels
release-process
Projects
None yet
Milestone
1.58.2 (17.9)
Development

Successfully merging this pull request may close these issues.
2 participants
@SiobhyB @fluiddot