Fix BottomSheet.SubSheet/TextInput Conflict #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiobhyB
added
[Type] Bug
7 tasks
dcalhoun
approved these changes
Aug 3, 2021
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Heads up that I've assigned this PR to the 1.58.2 milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: WordPress/gutenberg#33828
gutenberg:WordPress/gutenberg#33845Description
As outlined in WordPress/gutenberg#33828, the text editor for adding alt text to an image (accessed from the image block's settings) isn't currently working as expected. At the time of writing, the keyboard is immediately dismissed with each keystroke, making it extremely difficult, bordering on impossible, to add alt text to an image.
This issue was introduced with the changes to the BottomSheet.SubSheet component in WordPress/gutenberg@d650b4f. With this PR, I have refactored those changes in a way that enables the alt text entry to work as expected.
Testing
Please refer to the Gutenberg PR as the central and most up-to-date place for testing steps.
PR submission checklist: