Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed block: Enable replace option #3703

Merged
merged 3 commits into from
Jul 7, 2021
Merged

Embed block: Enable replace option #3703

merged 3 commits into from
Jul 7, 2021

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jul 7, 2021 •
edited
Loading

gutenberg PR: WordPress/gutenberg#33253

To test:
Follow the testing instructions described in gutenberg PR: WordPress/gutenberg#33253

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added this to the 1.57.0 (17.8) milestone Jul 7, 2021
@fluiddot fluiddot requested a review from ceyhun July 7, 2021 09:34
@fluiddot fluiddot self-assigned this Jul 7, 2021
@fluiddot fluiddot mentioned this pull request Jul 7, 2021
Merged
7 tasks
ceyhun
ceyhun approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via the gutenberg PR. Gutenberg commit hash will need an update after the gutenberg PR is merged to gutenberg/trunk.

@peril-wordpress-mobile
Copy link

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot merged commit 7460114 into develop Jul 7, 2021
@fluiddot fluiddot deleted the add/3285-embed-block-replace-option branch July 7, 2021 18:38
@fluiddot fluiddot linked an issue Jul 7, 2021 that may be closed by this pull request
[Embed block] Enable replace option #3285
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ceyhun ceyhun ceyhun approved these changes

Assignees

@fluiddot fluiddot

Labels
Embed block [Type] Task
Projects
None yet
Milestone
1.57.0 (17.8)
Development

Successfully merging this pull request may close these issues.

[Embed block] Enable replace option
2 participants
@fluiddot @ceyhun