[RNMobile] Embed block: Enable replace option #33253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluiddot
added
Mobile App - i.e. Android or iOS
fluiddot
commented
Jul 7, 2021
| @@ -238,6 +238,7 @@ const EmbedEdit = ( props ) => { | |||
| invalidateResolution( 'getEmbedPreview', [ url ] ); | |||
| } } | |||
| isSelected={ isSelected } | |||
| isEditingURL={ isEditingURL } | |||
There was a problem hiding this comment.
isEditingURL is true when the replace action is triggered.
fluiddot
commented
Jul 7, 2021
| @@ -39,7 +40,7 @@ const EmbedPlaceholder = ( { | |||
| [ clientId ] | |||
| ); | |||
| const [ isEmbedSheetVisible, setIsEmbedSheetVisible ] = useState( | |||
| isSelected && wasBlockJustInserted && ! value | |||
| isSelected && ( ( wasBlockJustInserted && ! value ) || isEditingURL ) | |||
There was a problem hiding this comment.
This change enables the bottom sheet to be automatically displayed when the replace action is triggered.
2 tasks
|
Size Change: +9 B (0%) Total Size: 1.06 MB
ℹ️ View Unchanged
|
ceyhun
requested changes
Jul 7, 2021
I'm not sure if I understood what you commented, do you mean that we should display the invalid error message for the value I'd like to note that |
I think
I think this was working before, because maybe we were using |
|
I think there are two different validations on this block:
Not sure, from the code, looks like the prepend happens before calling the gutenberg/packages/components/src/mobile/link-settings/index.native.js Lines 140 to 144 in 1eaad3c gutenberg/packages/components/src/mobile/link-settings/index.native.js Lines 162 to 173 in 1eaad3c |
Ah, I guess then |
ceyhun
approved these changes
Jul 7, 2021
No worries, I was also surprised when I saw that weird URLs like |
sarayourfriend
pushed a commit
that referenced
this pull request
Jul 15, 2021
* Add replace option to native version of embed block * Add invalid and empty URL cases to replace action
This was referenced Oct 14, 2021
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gutenberg-mobilePR: wordpress-mobile/gutenberg-mobile#3703Description
Implement and enable the replace option as described in this issue.
How has this been tested?
Replace URL
Invalid URL
http://)Empty URL
Screenshots
embed-block-replace-option.mp4
Types of changes
New feature
Checklist:
*.native.jsfiles for terms that need renaming or removal).