Remove usage of ColorEdit in the Button block #3691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
|
Tested with WordPress/gutenberg#33103 (review) and everything worked great! Can we rerun the bundle with this merge? That way I can include these changes with the merge of wordpress-mobile/WordPress-iOS#16411 |
chipsnyder
approved these changes
Jul 1, 2021
There was a problem hiding this comment.
Meant for this comment to be an approval not a comment :)
Also since your EOD I can help with the merge process here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg PR-> WordPress/gutenberg#33103After merging the Global styles implementation WordPress/gutenberg#30544 a bug was found where the color settings would show up duplicated for the Button block and the gradients option wouldn't show up. For more information and test plan check the Gutenberg PR description.
PR submission checklist: