-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Global Styles] Implement Global Styles endpoint #16411
Conversation
Generated by 🚫 dangerJS |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
You can trigger an installable build for these changes by visiting CircleCI here. |
3c9c396
to
2061a1f
Compare
# Conflicts: # Podfile # Podfile.lock # WordPress/Classes/Models/Blog.h # WordPress/Classes/Models/Blog.m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @chipsnyder 👍
I started reviewing this and I've run into an issue with a missing gradient selector. I was able to reproduce this on Android too thus this seems unrelated with this PR.
The code changes LGTM but I've seized testing for now till we find out when this was introduced.
@chipsnyder, @antonis, do you have an idea when the changes to GutenbergViewController will be merged here? I'm looking to set this PR as ready for review, but it's not currently building, which I believe is due to the changes from the merged Gutenberg PRs that this PR is connected to: Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Ran some tests to check there are no regressions and is all good! Nice work!
Fixes wordpress-mobile/gutenberg-mobile#3163
Related PRs
WordPressKit
[Global Styles] Implement Global Styles endpoint WordPressKit-iOS#394Gutenberg-Mobile
[Global Styles] Adds new Prop for Global Styles Settings gutenberg-mobile#3459Gutenberg
[RN Mobile][Global Styles] Adds new Prop for Global Styles Settings WordPress/gutenberg#30544This change is dependent on: WordPress/gutenberg#29969
To test:
You can enable and disable the feature by:
Regression Tests:
These should be run on a site with "Global Style Settings" disabled or a site that doesn't have WordPress 5.8 installed:
Tests:
These should be run on a site with "Global Style Settings" enabled and a site that has WordPress 5.8 installed:
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txt
if necessary.