Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Global Styles] Implement Global Styles endpoint #16411

Merged
merged 32 commits into from
Jul 1, 2021

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Apr 29, 2021

Fixes wordpress-mobile/gutenberg-mobile#3163
Related PRs

This change is dependent on: WordPress/gutenberg#29969

To test:

You can enable and disable the feature by:

  1. Clicking your Avatar from the My Site Screen
  2. Navigate to App Settings > Debug
  3. Toggle "Global Style Settings" for the desired Setting

Regression Tests:

These should be run on a site with "Global Style Settings" disabled or a site that doesn't have WordPress 5.8 installed:

  • Default Colors - Check that default colors still load - steps
  • Default Gradients - Check that default gradients still load - steps
  • Custom Colors - Check that custom colors load in the editor - steps
  • Custom Gradients - Check that custom gradients load in the editor - steps
  • Offline Support - steps

Tests:

These should be run on a site with "Global Style Settings" enabled and a site that has WordPress 5.8 installed:

  • FSE Colors and Gradients - steps
  • Offline Support - steps

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 29, 2021

Warnings
⚠️ PR is not assigned to a milestone.
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 29, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 29, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@chipsnyder chipsnyder requested review from geriux and antonis May 19, 2021 16:05
@chipsnyder chipsnyder force-pushed the gutenberg/issue/3163-gss branch from 3c9c396 to 2061a1f Compare June 16, 2021 21:18
Antonis Lilis and others added 4 commits June 25, 2021 11:37
# Conflicts:
#	Podfile
#	Podfile.lock
#	WordPress/Classes/Models/Blog.h
#	WordPress/Classes/Models/Blog.m
@chipsnyder chipsnyder marked this pull request as ready for review June 28, 2021 20:50
@chipsnyder chipsnyder added Core Data Issues related to Core Data and removed [Status] DO NOT MERGE [Status] In Progress labels Jun 28, 2021
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chipsnyder 👍
I started reviewing this and I've run into an issue with a missing gradient selector. I was able to reproduce this on Android too thus this seems unrelated with this PR.
The code changes LGTM but I've seized testing for now till we find out when this was introduced.

Screenshot

IMG_B1253007DCAD-1

@SiobhyB
Copy link
Contributor

SiobhyB commented Jul 1, 2021

@chipsnyder, @antonis, do you have an idea when the changes to GutenbergViewController will be merged here? I'm looking to set this PR as ready for review, but it's not currently building, which I believe is due to the changes from the merged Gutenberg PRs that this PR is connected to:

Screenshot 2021-06-30 at 23 20 57

Thanks in advance!

@chipsnyder
Copy link
Contributor Author

Hey @SiobhyB I'll work with @geriux to get this merged today since @antonis is AFK. Sorry about that delay and blocker.

Copy link
Contributor

@geriux geriux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ran some tests to check there are no regressions and is all good! Nice work!

@chipsnyder chipsnyder merged commit 7225dbd into develop Jul 1, 2021
@chipsnyder chipsnyder deleted the gutenberg/issue/3163-gss branch July 1, 2021 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants