-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add editor onboarding capability #3437
Conversation
6836b34
to
0845727
Compare
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
@jhnstn I debated as to whether we should attempt to merge these changes on their own or combine them with the first user-facing feature (i.e. the “Tap to add content” tooltip). I ultimately decided to proceed with opening a PR as-is. Because of this, the test plan is a bit more manual. I figured it might be better to receive your feedback sooner rather than later and also keep the code review focused on a smaller amount of changes. Let me know if believe it makes more sense to wait to merge this work until we complete the first tooltip. Regardless, I'd still appreciate your input on the approach thus far. Thanks! |
@dcalhoun I like shipping this change now before we get into the UI work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gutenberg PR approved 👍
39653d4
to
1404414
Compare
Add editor onboarding capability to control visibility of the feature. The flag combines (A) if the user has previously launched the Gutenberg editor and (B) if the user ID falls within the percentage of users allowed.
This flag is the first task of several to control when the editor onboarding is displayed. This flag will be used in combination with other, future flags (e.g.
tooltipsSeen
tracking which tips have been shown) to determine what should be displayed.To test:
As this PR and its siblings contain no user-facing changes, the following test plan involves logging out the newly added
capability
to ensure it is working properly. The value behind shipping this addition on its own is to (A) begin tracking editor launches sooner rather than later and (B) produce smaller code diffs to review.Patch to log editor onboarding flag
gutenberg-mobile
branch.cd gutenberg && git apply path/to/patch-file.diff && cd ..
>>> canViewEditorOnboarding true
is logged in the Metro server as it is the first time the editor has launched.>>> canViewEditorOnboarding false
is logged in the Metro server for all editor launches moving forward.PR submission checklist: