Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add editor onboarding capability #16406

Merged
merged 10 commits into from
May 13, 2021
Merged

Add editor onboarding capability #16406

merged 10 commits into from
May 13, 2021

Conversation

dcalhoun
Copy link
Member

@dcalhoun dcalhoun commented Apr 29, 2021 •
edited
Loading

Add editor onboarding capability to control visibility of the feature.

To test: Follow steps outlined in wordpress-mobile/gutenberg-mobile#3437.

Regression Notes

  1. Potential unintended areas of impact
    Modifications within Gutenberg editor lifecycle could cause editor to crash.
  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Ensured builds succeeded locally. Verified editor launched without error.
  3. What automated tests I added (or what prevented me from doing so)
    Includes no user-facing or critical routines to test.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dcalhoun dcalhoun added [Status] DO NOT MERGE Gutenberg Editing and display of Gutenberg blocks. Part of a WIP Feature labels Apr 29, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 29, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 29, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

This was referenced Apr 29, 2021
Merged
Merged
Merged
dcalhoun added 6 commits May 3, 2021 15:47
@dcalhoun
Enable Editor Onboarding features for dev and test environments
89a4aa9 
This should be removed once the feature is finished.
@dcalhoun
Add flag to track launch of Gutenberg editor
a060753 
Tracking whether a user has launched the Gutenberg editor enables
avoiding unnecessarily displaying the onboarding experience.
@dcalhoun
Update gutenberg reference
e7661c9
@dcalhoun
Install pods
71d96a3
@dcalhoun
Update gutenberg ref
c352adf
@dcalhoun
Update gutenberg ref
ac898e8
@dcalhoun dcalhoun self-assigned this May 6, 2021
@dcalhoun dcalhoun requested a review from jhnstn May 6, 2021 20:53
@dcalhoun dcalhoun marked this pull request as ready for review May 6, 2021 22:59
@dcalhoun dcalhoun added this to the 17.4 milestone May 12, 2021
@dcalhoun dcalhoun requested a review from illusaen May 12, 2021 14:45
illusaen
illusaen approved these changes May 12, 2021
View reviewed changes
Copy link
Contributor

@illusaen illusaen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcalhoun dcalhoun merged commit 61eb754 into develop May 13, 2021
@dcalhoun dcalhoun deleted the add/editor-onboarding-capability branch May 13, 2021 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illusaen illusaen illusaen approved these changes

@jhnstn jhnstn Awaiting requested review from jhnstn

Assignees

@dcalhoun dcalhoun

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
17.4
Development

Successfully merging this pull request may close these issues.
2 participants
@dcalhoun @illusaen