-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary gutenberg update to test media files type #3113
Conversation
@wendyjchen @mzorz I think the two of you were taking a look at this issue cropping up in iOS where an error screen is shown when editing Stories. This is the necessary fix to the Swift type used in the Gutenberg delegate methods. The actual editing implementation isn't in WPiOS yet, so nothing will happen when hitting the editing button after merging this (as opposed to the error showing). |
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
@guarani After some struggling with npm issue, I think the bundle finally worked correctly. Could you check and see that this looks right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested via the WPiOS PR and looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 I realised that this PR has introduced the yarn.lock
file, does this mean that we can start using it as an alternative to NPM?
Fixes an error when the media files delegate methods are called on iOS.
See wordpress-mobile/WordPress-iOS#15811
See WordPress/gutenberg#28766
To test:
PR submission checklist:
I have considered adding unit tests where possible.Didn't see a place to test this