Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary gutenberg update to test media files type #3113

Merged
merged 6 commits into from
Feb 11, 2021

Conversation

bjtitus
Copy link
Contributor

@bjtitus bjtitus commented Feb 5, 2021

Fixes an error when the media files delegate methods are called on iOS.

See wordpress-mobile/WordPress-iOS#15811
See WordPress/gutenberg#28766

To test:

  • Open a post containing a stories block
  • Attempt to edit the block
  • With this change, no error should be shown
  • Without this change, an error screen is shown (see above)

PR submission checklist:

  • I have considered adding unit tests where possible. Didn't see a place to test this
  • !I have considered if this change warrants user-facing release notes.~ Unreleased on iOS.

@bjtitus
Copy link
Contributor Author

bjtitus commented Feb 5, 2021

@wendyjchen @mzorz I think the two of you were taking a look at this issue cropping up in iOS where an error screen is shown when editing Stories. This is the necessary fix to the Swift type used in the Gutenberg delegate methods. The actual editing implementation isn't in WPiOS yet, so nothing will happen when hitting the editing button after merging this (as opposed to the error showing).

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Feb 8, 2021

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@bjtitus bjtitus requested a review from mzorz February 9, 2021 21:20
@bjtitus
Copy link
Contributor Author

bjtitus commented Feb 10, 2021

@guarani After some struggling with npm issue, I think the bundle finally worked correctly. Could you check and see that this looks right?

@bjtitus bjtitus requested review from guarani and removed request for etoledom February 10, 2021 21:43
Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via the WPiOS PR and looks good!

@bjtitus bjtitus merged commit 5e1c41e into develop Feb 11, 2021
@bjtitus bjtitus deleted the stories/mediaFiles-type branch February 11, 2021 19:40
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 I realised that this PR has introduced the yarn.lock file, does this mean that we can start using it as an alternative to NPM?

@dcalhoun dcalhoun mentioned this pull request Feb 16, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants