-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Stories] Temporary gutenberg update for media files type #15811
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Podfile.lock
Outdated
@@ -73,7 +73,7 @@ PODS: | |||
- GTMSessionFetcher/Core (1.5.0) | |||
- GTMSessionFetcher/Full (1.5.0): | |||
- GTMSessionFetcher/Core (= 1.5.0) | |||
- Gutenberg (1.46.0): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just came here from WordPress/gutenberg#28766 and noticed that this is going down a version (1.46.0 to 1.45.0), could your Gutenberg Mobile or Gutenberg branches need updating?
# Conflicts: # Podfile.lock
👋 We're freezing |
Podfile
Outdated
@@ -154,7 +154,8 @@ target 'WordPress' do | |||
## Gutenberg (React Native) | |||
## ===================== | |||
## | |||
gutenberg :tag => 'v1.46.0' | |||
#gutenberg :tag => 'v1.46.0' | |||
gutenberg :commit => 'dcacde' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I undid this change temporarily on my machine, ran rake xcode
and ran the project – without the packager running – expecting to see the red error screen, and I didn't get an error when I opened the story post.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get an error either when running the packager on the Gutenberg Mobile branch, which is a good thing, but I expected to be able to reproduce the error by undoing the above change but wasn't successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 @bjtitus, I'm not sure if you're planning on merging this PR, or just letting the Gutenberg Mobile changes get incorporated into WPiOS in the next release. I guess your options include:
a. If you want these changes incorporated immediately into WPiOS develop
(e.g. because you need to do more work that depends on this), you'll need to run npm run bundle
in the gutenberg-mobile directory, commit the results and push to your PR. Then you'll have to update this PR to point to that latest commit
b. However, if this change isn't needed rightaway (i.e. no PRs this week or next depend on it), you can use this PR only for testing. If this is the case, you can close this PR once the Gutenberg and Gutenberg Mobile PRs are ready and merged. In this scenario, this PR is only used for creating an App Center build with your Gutenberg changes.
Let me know if you need a hand with any of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and looking good!
# Conflicts: # Podfile.lock
Fixes an incorrect type in the GutenbergBridgeDelegate methods for the "media files" block (a.k.a. Stories).
See wordpress-mobile/gutenberg-mobile#3113
See WordPress/gutenberg#28766
Testing
PR submission checklist:
RELEASE-NOTES.txt
if necessary.