Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme colors sync #2788

Merged
merged 2 commits into from
Nov 17, 2020
Merged

Theme colors sync #2788

merged 2 commits into from
Nov 17, 2020

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Nov 9, 2020 •
edited
Loading

Gutenberg PR -> WordPress/gutenberg#26821
WordPress iOS PR -> wordpress-mobile/WordPress-iOS#15258
WordPress Android PR -> wordpress-mobile/WordPress-Android#13327

Fixes an issue with theme colors not syncing correctly.

More description and testing cases available in the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Nov 9, 2020
Merged
Closed
Closed
@geriux geriux requested a review from chipsnyder November 10, 2020 13:45
@geriux geriux marked this pull request as ready for review November 10, 2020 13:45
@geriux geriux added this to the 1.42 milestone Nov 10, 2020
@geriux geriux force-pushed the fix/theme-colors-sync branch from 8791a45 to c3dff5a Compare November 13, 2020 13:58
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Nov 13, 2020 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

chipsnyder
chipsnyder approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@chipsnyder chipsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: WordPress/gutenberg#26821 (review)

@geriux geriux force-pushed the fix/theme-colors-sync branch from c3dff5a to 8d38f7f Compare November 17, 2020 10:12
@geriux geriux merged commit 365eb35 into develop Nov 17, 2020
@geriux geriux deleted the fix/theme-colors-sync branch November 17, 2020 11:36
@cameronvoell cameronvoell mentioned this pull request Nov 23, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipsnyder chipsnyder chipsnyder approved these changes

Assignees
No one assigned
Labels
Page Templates
Projects
None yet
Milestone
1.42 (16.3)
Development

Successfully merging this pull request may close these issues.
2 participants
@geriux @chipsnyder