-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Theme changes (colors) are not applied until you close and reopen the editor #2637
Comments
Hey @antonis I have a question on what you're experiencing to make sure I'm seeing the same issue.
|
@chipsnyder I confirm that I see the same behavior with your steps. The second time I open the editor the theme is applied. |
Awesome thanks @antonis it seems like this might be a case of the update event being lost as part of the bridge call. Now that we've done some work to improve that communication I'll look to see if there is a better API we can use to ensure those payloads go through |
For the theme showing up with the wrong values, it looks like there might be a timing issue. If the new theme downloads and calls update before the editor loads then the editor will load with the correct theme then revert back to the wrong values do to the initial theme finally being passed. |
Describe the bug
When you switch theme in the app the theme color palette does not change. This is reproduced both on iOS and Android.
If you switch site and get back, the theme changes are applied.If you close the editor and reopen it, the theme changes are applied.
To Reproduce
Steps to reproduce the behavior:
Switch to another siteClose the editorSwitch back to the original siteCreate a post/pageExpected behavior
The palette colors should change (step 7) when the user changes theme
Screenshots
A video replicating the issue can be downloaded here.
Smartphone (please complete the following information):
The text was updated successfully, but these errors were encountered: