Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.40.0 #2758

Merged
merged 48 commits into from
Oct 29, 2020
Merged

Release 1.40.0 #2758

merged 48 commits into from
Oct 29, 2020

Conversation

cameronvoell
Copy link
Contributor

@cameronvoell cameronvoell commented Oct 26, 2020

Release for Gutenberg Mobile 1.40.0

Related PRs

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Approve and run optional Android and iOS UI tests
  • Aztec dependencies are pointing to a stable release.
    • iOS: Aztec dependencies match in RNTAztecView.podspec and gutenberg/packages/react-native-aztec/RNTAztecView.podspec.
  • Check if RELEASE-NOTES.txt and gutenberg/packages/react-native-editor/CHANGELOG.md are updated with all the changes that made it to the release.
  • Bundle package of the release is updated.

jd-alexander and others added 30 commits September 22, 2020 18:03
…_bundle_files

Remove auto-generated files from bundle and add to .gitignore
…k_inserter_accessibility

Improve block inserter accessibility
 # Please enter the commit message for your changes. Lines starting
)

* Update guteneberg

* Revert Jetpack change
This project now requires both npm and yarn because Jetpack uses yarn.
…requisites

Add Yarn to README Prerequisites
…o_develop

Merge release 1.39.0 to develop
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 26, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@cameronvoell cameronvoell marked this pull request as ready for review October 27, 2020 00:38
@antonis
Copy link

antonis commented Oct 27, 2020

iOS Sanity Testing Results

Tested with build number: 36877 from App Center on a iPhone SE 2020 with iOS 14.2

DarkMode-2

  • Spacer block - Dark mode - steps
  • Buttons block - Dark mode - steps
  • Group - Dark mode - steps
  • Columns - Dark mode - steps

Group-2

  • Group - Navigation up button works as expected - steps
  • Group - Navigation down works according to parent-first approach - steps
  • Group - Cross navigation between blocks works as expected - steps
  • Group - Ungroup button works as expected - steps
  • Group - Check if in DarkMode all components gets proper colors - steps
  • Group - Check if nested Placeholder block can be replaced - steps

Spacer-2

  • Spacer block - Settings: Available height range is correct - steps
The slider allows to minimum value of 1px. The same holds true for the Web.

This seems to be an intentional change and the test case needs to be updated.

Mobile Web
IMG_0011 Screenshot 2020-10-27 at 1 49 20 PM
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
When setting this in HTML it produces an error on mobile. On the web this seems to work sometimes (like below) but not consistently Opened #2761 to track this
Web HTML Mobile
Screenshot 2020-10-27 at 2 09 35 PM Screenshot 2020-10-27 at 2 09 49 PM IMG_E6D78075FC7D-1
  • Spacer block - Spacer in horizontal layout works as expected - steps

Buttons-4

  • Buttons block - Render custom text color - steps
  • Buttons block - Render custom background color - steps
  • Buttons block - Render gradient background color - steps
  • Buttons block - Check if selection / caret color matches font color - steps
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps

Button-5

  • Buttons block - Edit text styles - steps
  • Buttons block - Render theme colors - steps
  • Buttons block - Settings: Change Button border radius - steps

Button-7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
  • Buttons block - Toolbar link button is active when Button has link - steps

Editor Theme - 2

  • Custom Gradients - Check that custom gradients load in the editor - steps
  • Offline Support - steps

Color Settings - 2

  • Pressing color swatch - steps
  • Customize gradient color - steps
  • Custom color picker - steps

@cameronvoell
Copy link
Contributor Author

cameronvoell commented Oct 28, 2020

Android Testing ✅ , Results below:

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text forma

@ceyhun
Copy link
Contributor

ceyhun commented Oct 29, 2020

Tested with iPhone 11 Pro, iOS 14.1, build 36877:

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

@cameronvoell
Copy link
Contributor Author

Testing with WPAndroid.

DarkMode-2

  • Spacer block - Dark mode - steps
  • Buttons block - Dark mode - steps
  • Group - Dark mode - steps
  • Columns - Dark mode - steps

Group-2

  • Group - Navigation up button works as expected - steps
  • Group - Navigation down works according to parent-first approach - steps
  • Group - Cross navigation between blocks works as expected - steps
  • Group - Ungroup button works as expected - steps
  • Group - Check if in DarkMode all components gets proper colors - steps
  • Group - Check if nested Placeholder block can be replaced - steps

Spacer-2

  • Spacer block - Settings: Available height range is correct - steps
  • Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
  • Spacer block - Spacer in horizontal layout works as expected - steps

Button-4

  • Buttons block - Render custom text color - steps
  • Buttons block - Render custom background color - steps
  • Buttons block - Render gradient background color - steps
  • Buttons block - Check if selection / caret color matches font color - steps
  • Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps

Button-5

  • Buttons block - Edit text styles - steps
  • Buttons block - Render theme colors - steps
  • Buttons block - Settings: Change Button border radius - steps

Button-7

  • Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
  • Buttons block - Toolbar link button is active when Button has link - steps

Color Settings-2

  • Pressing color swatch - steps
  • Customize gradient color - steps
  • Custom color picker - steps

@cameronvoell
Copy link
Contributor Author

Thanks @ceyhun and @antonis for the tests! Looks like we're all green except some minor behavior around setting spacer height outside the allowed range through html which @antonis create a ticket for (thank you!). Looks good to go from my perspective 👍

Copy link
Contributor

@ceyhun ceyhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

…image

Pin circleci/android:api-29-node docker image to previous version with node 12
@cameronvoell cameronvoell merged commit f9c2027 into trunk Oct 29, 2020
@cameronvoell cameronvoell deleted the release/1.40.0 branch October 29, 2020 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants