Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Yarn to README Prerequisites #2739

Merged
merged 1 commit into from
Oct 17, 2020
Merged

Add Yarn to README Prerequisites #2739

merged 1 commit into from
Oct 17, 2020

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Oct 17, 2020 •
edited
Loading

We now require yarn for the build, so just adding that as a prerequisite in the README.

Please feel free to go ahead and merge this if you approve it. 🙇

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@mchowning
Add Yarn to Readme Prerequisites
31bc585 
This project now requires both npm and yarn because Jetpack uses yarn.
@mchowning mchowning added the Jetpack Bug or feature related to Jetpack label Oct 17, 2020
@mchowning mchowning added this to the 1.40 milestone Oct 17, 2020
@mchowning mchowning requested review from mzorz and etoledom October 17, 2020 14:51
mzorz
mzorz approved these changes Oct 17, 2020
View reviewed changes
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mzorz
Copy link
Contributor

mzorz commented Oct 17, 2020

Thank you @mchowning !

@mzorz mzorz merged commit 31088a0 into develop Oct 17, 2020
@mzorz mzorz deleted the add_yarn_to_readme_prerequisites branch October 17, 2020 16:00
@cameronvoell cameronvoell mentioned this pull request Oct 27, 2020
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzorz mzorz mzorz approved these changes

@etoledom etoledom Awaiting requested review from etoledom

Assignees
No one assigned
Labels
Jetpack Bug or feature related to Jetpack
Projects
None yet
Milestone
1.40
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @mzorz