Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/1.31.0 #2423

Merged
merged 199 commits into from
Jun 26, 2020
Merged

Release/1.31.0 #2423

merged 199 commits into from
Jun 26, 2020

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Jun 24, 2020

Release for Gutenberg Mobile 1.31.0

Related PRs

N/A
  • Aztec-iOS
  • Aztec-Android

Extra PRs that Landed After the Release Was Cut

Changes

Test plan

  • Use the main WP apps to test the changes above.
  • Check WPAndroid and WPiOS PRs if there are specific tests to run.
  • Smoke test the main WP apps for general writing flow.

Release Submission Checklist

  • Release number was bumped
  • Aztec dependencies are pointing to a stable release
    • iOS: 'grep WordPressAztec-iOS RNTAztecView.podspec'
    • Android: 'grep aztecVersion react-native-aztec/android/build.gradle'
  • Gutenberg 'Podfile' and 'Podfile.lock' inside './ios/' are updated to the release number
  • Bundle package of the release is updated
  • Check if RELEASE-NOTES.txt is updated with all the changes that made it to the release

Tug and others added 30 commits April 21, 2020 22:18
@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented Jun 24, 2020

Testing the Writing Flow on iOS:

Writing Flow checklist:

  • TC001 - Block insertion flow
  • TC001 - Paste formatted text copied from website
  • TC001 - Multiline components
  • Rich Text Format
    • TC001 - Bold, Italic, strikethrough buttons
    • TC002 - Alignment buttons
    • TC003 - Alignment Split
    • TC004 - Link button works without selection
    • TC005 - Link button works with a selected word
    • TC006 - Adding a link from a copied URL
    • TC007 - Test format detection under the cursor
    • TC008 - Test formatting doesn't remove leading or trailing whitespace
  • Splitting and merging
    • TC001 - Merge after writing
    • TC002 - Merge after selection
    • TC003 - Merge after deleting text
    • TC004 - Merge after deleting all
    • TC005 - Merge multiple blocks
    • TC006 - Splitting/merge list block
  • Undo / Redo - Test Cases
    • TC001 - Undo/redo block actions
    • TC002 - Undo/redo text
    • TC003 - Undo/redo text format

@mchowning
Copy link
Contributor

mchowning commented Jun 24, 2020

Ran the Writing Flow tests on Android and found no issues. 🙂

@enejb
Copy link
Contributor

enejb commented Jun 25, 2020

Gallery-1

  • Gallery block - Close/Re-open post with an ongoing image upload - steps
  • Gallery block - Close post with an ongoing image upload - steps

Gallery-2

  • Gallery block - Insert image from device (failing) - steps
  • Gallery block - Insert image from device (cancel) - steps

Gallery-3

  • Gallery block - Add Gallery Caption - steps
  • Gallery block - Add Gallery Image Caption - steps
  • Gallery block - Try adding same images from WP Media library and moving the images around - steps

Columns - 1

  • Columns - Columns block is added with default number of Column - steps
  • Columns - Adding Column with AppenderButton - steps
  • Columns - Adding and removing Column with BottomSheet Stepper control - steps

Columns - 2

  • Columns - Max limit of Column number - steps
  • Columns - Min limit of Column number - steps
  • Columns - Removing Column with remove button - steps
  • Columns - Removing the only one left Column with remove button - steps
  • Columns - Changing alignment on Columns - steps
  • Columns - Changing alignment on individual Columnn - steps
  • Columns - Alignment attribute is properly passed when adding Column - steps
  • Columns - Deep nesting is possible (iOS only)- steps

Columns - 3

  • Columns - Check if Column placeholders is visible for the unselected state - steps
  • Columns - Appearance in vertical device position (vertical layout) - steps
  • Columns - Appearance in horizontal device position (horizontal layout) - steps
  • Columns - Mover direction - steps
  • Columns - Check if Column placeholder is render in nested structure - steps
  • Columns - Unselected Column placeholder is streched to content in nested structure- steps

MediaText-1

  • Media Text block - Insert image from device (failing) - steps
  • Media Text block - Close/Re-open post with an ongoing image upload - steps

MediaText-2

  • Media Text block - Insert video from device (cancel) - steps
  • Media Text block - Insert image from device (cancel) - steps

MultipleUpload-1

  • Simultaneous uploads - steps

Cover-1

  • Cover - Add image background from WordPress Media library - steps
  • Cover - Change Minimum height in pixels - steps
  • Cover - Change Background Opacity - steps
  • Cover - Image focal point is rendered properly - steps
  • Cover - Custom color is rendered properly - steps

While testing I recorded the following issues.

Media Text: When changing images and canceling the process make sure to preserve the previous image
#2430

Media Text: Failed to insert media overlay has icon that is different colour from text
#2429

iOS, Gallery Settings: Show the currently selected gallery option and settings label
#2428

Columns Block: No limit to the number of columns that can be placed inside the column block
#2425

Columns Block: Removing column with content should prompt you to confirm
#2431

Copy link
Contributor

@mchowning mchowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in good shape! :shipit:

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 26, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@SergioEstevao SergioEstevao merged commit e9a6579 into main Jun 26, 2020
@SergioEstevao SergioEstevao deleted the release/1.31.0 branch June 26, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.