Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery Settings: You should show the currently selected option and settings label before you change. #2428

Closed
enejb opened this issue Jun 25, 2020 · 3 comments

Comments

@enejb
Copy link
Contributor

enejb commented Jun 25, 2020

Describe the bug
Currently when you are editing the gallery options such as Link to or Image Size.

There is no indication what is selected or what option you are editing.

See:
Screen Shot 2020-06-25 at 10 28 54 AM

Is that intended?

My proposal would be to provide a title and display the setting. In order to make it more clear what the setting is that we are changing.
As well as a checkmark next to the currently selected value so that we know what he current value of the setting is.

To Reproduce
Steps to reproduce the behavior:

  1. Add a gallery block.
  2. Choose the gear icon to get to the gallery settings.
  3. Click on "Link to"

Expected behavior
An indication that that you are editing the "Link to" setting as well as the current selection.

Screenshots
Screen Shot 2020-06-25 at 10 28 54 AM

@enejb enejb added [Type] Bug Something isn't working [Status] Needs Design labels Jun 25, 2020
@enejb enejb mentioned this issue Jun 25, 2020
5 tasks
@enejb enejb changed the title iOS: Show the currently selected gallery option iOS, Gallery Settings: Show the currently selected gallery option and settings label Jun 25, 2020
@enejb enejb added Proposal and removed [Type] Bug Something isn't working labels Jun 25, 2020
@enejb enejb changed the title iOS, Gallery Settings: Show the currently selected gallery option and settings label iOS, Gallery Settings: You should show the currently selected option and settings label before you change. Jun 25, 2020
@pinarol
Copy link
Contributor

pinarol commented Jun 25, 2020

It should be possible to put a title to the action sheet but it will take some extra space and I am not sure if it is worth it. And plus, Android doesn't have it so it'll require a different development. TBH, I think we don't need to worry about this much, the action sheet component is integrated in the editor almost from the beginning and it is displayed in multiple places. We haven't heard any complaints about what is being edited is not clear. Not sure what @iamthomasbishop thinks about it though.

@iamthomasbishop
Copy link
Contributor

I think adding a descriptive header to the top of the actionSheet would be worthy usage of the space, so I'd be fine with adding one. However, I think there is some on-going work on the link settings (by @mkevins) so it might not make sense to implement something here that'll be overridden with any of that work. If we do decide to add a header to the sheet here, we should add it as a small section title on the Android bottom sheet.

@chipsnyder chipsnyder changed the title iOS, Gallery Settings: You should show the currently selected option and settings label before you change. Gallery Settings: You should show the currently selected option and settings label before you change. Feb 10, 2021
@antonis
Copy link

antonis commented Jan 24, 2022

Closing this issue as the selection is more clear with the new Gallery block implementation with nested images. Please reopen if that is not the case.

@antonis antonis closed this as completed Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants