Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link insertion at start of lists. #2323

Merged
merged 3 commits into from
May 27, 2020

Conversation

SergioEstevao
Copy link
Contributor

Fixes #2319

To test:

  • Follow the steps in the ticket above
  • Beside fixing the issue the caret selection should be positioned at the end of the links after insertion.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@SergioEstevao SergioEstevao added this to the 1.29 milestone May 26, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 26, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@Tug
Copy link
Contributor

Tug commented May 27, 2020

Just tested the PR. It seems that the cursor does move to the end when adding a new link but it doesn't work when converting existing text. Thus the bug described in #2319 is still reproducible.

Copy link
Contributor

@guarani guarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested the PR. It seems that the cursor does move to the end when adding a new link but it doesn't work when converting existing text. Thus the bug described in #2319 is still reproducible.

@SergioEstevao told me this ended up being a non-issue.


Tested scenarios on iOS & Android working as expected

  • ✅ Add link to existing text
  • ✅ Add link and text to the end of exiting text
  • ✅ Multi-line links
  • ✅ Deleting and editing links

@SergioEstevao SergioEstevao merged commit 8df575e into develop May 27, 2020
@SergioEstevao SergioEstevao deleted the issue/2319_fix_link_insertion_on_lists branch May 27, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linked text disappears after pressing enter
3 participants