Move selection to end of link after insertion. #22652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the selection is refreshed after changed.
SergioEstevao
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
|
Hey @SergioEstevao haven't tested it myself yet but I see a test is failing – not sure if flaky tests so I reran the tests so we can check back tomorrow. |
|
I'm holding off testing because of the bug that @Tug reported here. |
guarani
approved these changes
May 27, 2020
There was a problem hiding this comment.
Working great, tested here: wordpress-mobile/gutenberg-mobile#2323 (review)
SergioEstevao
added a commit
that referenced
this pull request
May 27, 2020
Make sure the selection is refreshed after changed.
5 tasks
mchowning
added a commit
that referenced
this pull request
Jun 1, 2020
* Remove Keyboard.dismiss() when deleting block * Move selection to end of link after insertion. (#22652) Make sure the selection is refreshed after changed. * Only show pullquote block on iOS. * Allow pullquote block to show on Android Dev builds * Change indentifier type in Button, correct concatenation in merge function (#22708) * [RNMobile] Fix footer appender in buttons block (#22711) * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes (#22716) * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes * add renderFooterAppender to the extraData to re-render list * small refactor * Add onDeleteBlock to the extra data to re-render when it has changes * [RNMobile] Correct color selection in color settings (#22736) * [RNMobile] Fix: Add default value to format when start and end are undefined (#22741) * add default vale to format when start and end are undefined * revert lint changes * Fix lint issue Co-authored-by: lukewalczak <[email protected]> Co-authored-by: Sérgio Estêvão <[email protected]> Co-authored-by: Drapich Piotr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the caret position to be at the end of the link, after insertion or change. This follows the same approach that was implemented on the web here: #17126
It also fixes the issue described here: wordpress-mobile/gutenberg-mobile#2319
How has this been tested?
This can be tested using the PR on GB-Mobile here: wordpress-mobile/gutenberg-mobile#2323
Screenshots
Types of changes
Bugfix and enhancement.
Checklist: