Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix displaying blocks with HTML anchor #2311

Merged
merged 6 commits into from
Jun 2, 2020
Merged

Fix displaying blocks with HTML anchor #2311

merged 6 commits into from
Jun 2, 2020

Conversation

ceyhun
Copy link
Contributor

@ceyhun ceyhun commented May 25, 2020

Fixes #2000

Also added group block example to initial html and anchors to heading and group blocks

To test: see Gutenberg PR WordPress/gutenberg#22604

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented May 25, 2020

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<!-- /wp:heading -->

<!-- wp:group -->
<div id="this-is-another-anchor" class="wp-block-group"><div class="wp-block-group__inner-container"><!-- wp:paragraph -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finding Groups using Anchors too!

@ceyhun ceyhun merged commit 5789344 into develop Jun 2, 2020
@ceyhun ceyhun deleted the add/anchor-support branch June 2, 2020 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding HTML anchor to heading block creates a problem displaying block in app
2 participants