-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Fix displaying blocks with HTML anchor #22604
Conversation
Size Change: -15.3 kB (1%) Total Size: 1.11 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ceyhun for this PR, it's working great 🎉
I left a code comment, please let me know your opinion about it 👍
packages/block-editor/src/components/inspector-advanced-controls/index.native.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @ceyhun !
It's working great 🎉
Thanks for the update 🙏
Description
Fixes: wordpress-mobile/gutenberg-mobile#2000
Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#2311
Enabled hooks injecting anchor to block on mobile side and used
null
for the UI that lets you edit the HTML anchor on the web.How has this been tested?
Heading
blockid
to the HTML tag of heading blockGroup
blockScreenshots
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist: