-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable verse block #2185
Enable verse block #2185
Conversation
I'd love to hear if there's a better workflow to create downloadable builds. For this PR, I ran these commands and committed the results:
This allows the associated PRs, wordpress-mobile/WordPress-iOS#14004 and wordpress-mobile/WordPress-Android#11763 to find a packaged |
At this time I think that's necessary for iOS. Android doesn't need the bundles because they're handled by jitpack, but it's probably better to go ahead and bundle both to keep them in sync. I agree that it does make it very painful to review PRs. I definitely think we should try to work toward not including the bundles in the repo like this eventually. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All working well, extra kudos for adding the unit tests!
Thanks @SergioEstevao, merged now! 🎆 |
Addresses #1886
To test: See WordPress/gutenberg#21883
PR submission checklist:
RELEASE-NOTES.txt
if necessary.