Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test build for verse block #14004

Closed
wants to merge 4 commits into from
Closed

Create test build for verse block #14004

wants to merge 4 commits into from

Conversation

guarani
Copy link
Contributor

@guarani guarani commented Apr 27, 2020 •
edited
Loading

Addresses: wordpress-mobile/gutenberg-mobile#1886
Related:

To test: See WordPress/gutenberg#21883

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2020 •
edited
Loading

Warnings
⚠️ PR is not assigned to a milestone.

Generated by 🚫 dangerJS

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2020 •
edited
Loading

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 28725. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@guarani guarani self-assigned this Apr 27, 2020
@guarani guarani mentioned this pull request Apr 27, 2020
Merged
6 tasks
@guarani guarani changed the title Temp pointing to feature branches Create test build for verse block Apr 27, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Apr 27, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@guarani guarani mentioned this pull request Apr 28, 2020
Merged
2 tasks
@etoledom
Copy link
Contributor

etoledom commented May 5, 2020

@guarani - It seems we need to run rake dependencies and commit the changes to fix the build tests

@guarani
Copy link
Contributor Author

guarani commented May 5, 2020

@guarani - It seems we need to run rake dependencies and commit the changes to fix the build tests

Thanks for the heads up, I forgot to do that after updating the gutenberg-mobile branch.

@guarani guarani force-pushed the gutenberg/enable-verse-block branch from f088cbc to 773bb25 Compare May 5, 2020 16:04
@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label May 7, 2020
@guarani guarani force-pushed the gutenberg/enable-verse-block branch from fd8244a to 3b019a4 Compare May 8, 2020 16:52
@guarani guarani force-pushed the gutenberg/enable-verse-block branch from 93a0ae3 to 08e6567 Compare May 12, 2020 19:55
@guarani guarani closed this May 18, 2020
@guarani guarani deleted the gutenberg/enable-verse-block branch May 18, 2020 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@guarani guarani

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guarani @etoledom