Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/2073 disable category select #2074

Merged
merged 6 commits into from
Mar 30, 2020
Merged

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Mar 27, 2020

Fixes: #2073
gutenberg WordPress/gutenberg#21203

Description

WordPress 5.4 adds support for Multi-Select on Categories in the Latest-Posts Block. This places this setting behind a development flag until support is added on Mobile.

How has this been tested?

This can be tested from the builds:
iOS: wordpress-mobile/WordPress-iOS#13760
Android: wordpress-mobile/WordPress-Android#11548

Launching a Latest-Post block should hide the Categories option in the block settings.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder added bugfix Web breakage Caused by incompatible changes on Gutenberg web labels Mar 27, 2020
@chipsnyder chipsnyder added this to the 1.25 milestone Mar 27, 2020
@chipsnyder chipsnyder requested review from geriux and pinarol March 27, 2020 15:48
@chipsnyder chipsnyder marked this pull request as ready for review March 27, 2020 15:49
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pinarol pinarol merged commit 63cd071 into develop Mar 30, 2020
@pinarol pinarol deleted the issue/2073-disableCategorySelect branch March 30, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Web breakage Caused by incompatible changes on Gutenberg web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants