-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Disable Category selection in release #21203
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 856 kB ℹ️ View Unchanged
|
This was referenced Mar 27, 2020
pinarol
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Tested with installing the ipa from WPiOS PR. No Category selection is available anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: wordpress-mobile/gutenberg-mobile#2073
gutenberg-mobile
#21203Description
WordPress 5.4 adds support for Multi-Select on Categories in the Latest-Posts Block. This places this setting behind a development flag until support is added on Mobile.
How has this been tested?
This can be tested from the builds:
iOS:
wordpress-mobile/WordPress-iOS#13760Android:
wordpress-mobile/WordPress-Android#11548Launching a Latest-Post block should hide the Categories option in the block settings.
Screenshots
Types of changes
Removes setting feature.
Checklist: