Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: hide FloatingToolbar for root list block #1968

Merged
merged 3 commits into from
Mar 4, 2020
Merged

Fix: hide FloatingToolbar for root list block #1968

merged 3 commits into from
Mar 4, 2020

Conversation

jbinda
Copy link
Contributor

@jbinda jbinda commented Feb 28, 2020 •
edited
Loading

Fixes #1960

Please also refer to:
Related gutenberg PR
Related gutenberg-mobile issue

It presents:
Hide FloatingToolbar for root list blocks ( reverts unwanted changes from this PR )

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jbinda jbinda requested a review from pinarol February 28, 2020 10:30
@jbinda jbinda self-assigned this Feb 28, 2020
@jbinda jbinda mentioned this pull request Feb 28, 2020
Merged
6 tasks
@jbinda jbinda requested a review from dratwas March 4, 2020 12:20
@jbinda jbinda merged commit 00f6f03 into develop Mar 4, 2020
@jbinda jbinda deleted the callstack/hide-floating-toolbar branch March 4, 2020 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dratwas dratwas dratwas approved these changes

@pinarol pinarol Awaiting requested review from pinarol

Assignees

@jbinda jbinda

Labels
Blocks bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide FloatingToolbar for top level blocks that doesn't have nesting capabilities
2 participants
@jbinda @dratwas