-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] refine Block borders #20064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbinda
added
[Type] Enhancement
A suggestion for improvement.
[Feature] Blocks
Overall functionality of blocks
labels
Feb 6, 2020
2 tasks
jbinda
commented
Feb 10, 2020
packages/block-editor/src/components/block-list/index.native.js
Outdated
Show resolved
Hide resolved
etoledom
added
the
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
label
Feb 10, 2020
koke
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. Yay for less code 😁
so happy to see some complex logic removed! 🥳 |
This was referenced Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Feature] Blocks
Overall functionality of blocks
Mobile App - i.e. Android or iOS
Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
[Type] Enhancement
A suggestion for improvement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR goal is to apply
InnerBlock
bordering style to other blocks on the RootList level ( full solid border ) as well as showFloatingToolbar
when selected.At this moment two commits is the minimum code change to achieve expected results. I will also do the code cleanup to remove unnecessary code in future commits.
Please also refer to:
Related gutenberg-mobile PR
Discussion on design
How has this been tested?
initial-html
Screenshots
Types of changes
New feature ( apply same bordering style as in InnerBlock to RootList blocks )
Checklist: