Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/add gallery colors #1647

Merged
merged 4 commits into from
Dec 4, 2019
Merged

Fix/add gallery colors #1647

merged 4 commits into from
Dec 4, 2019

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Dec 4, 2019

This PR adds gallery colors to unblock metro build, and disables gallery block temporarily (will re-enable in the main gallery PR).

Related gutenberg PR: WordPress/gutenberg#18910

To test:

The demo app should build without error, and metro build should not fail.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@mkevins mkevins requested a review from pinarol December 4, 2019 12:57
@mkevins mkevins marked this pull request as ready for review December 4, 2019 12:59
@mkevins mkevins added the bugfix label Dec 4, 2019
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with both demo app and WPiOS app with a post that has Gallery block. There's no crash on both.

@mkevins mkevins merged commit d8f20fb into develop Dec 4, 2019
@mkevins mkevins deleted the fix/add-gallery-colors branch December 4, 2019 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants