Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mobile] Disable gallery block for now #18910

Merged
merged 1 commit into from
Dec 4, 2019
Merged

[Mobile] Disable gallery block for now #18910

merged 1 commit into from
Dec 4, 2019

Conversation

mkevins
Copy link
Contributor

@mkevins mkevins commented Dec 4, 2019 •
edited
Loading

Description

This PR temporarily disables mobile gallery block (will re-enable in the main gallery PR).

Related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#1647

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@mkevins mkevins added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Block] Gallery Affects the Gallery Block - used to display groups of images labels Dec 4, 2019
@mkevins mkevins requested a review from pinarol December 4, 2019 12:59
@mkevins mkevins mentioned this pull request Dec 4, 2019
Merged
1 task
pinarol
pinarol approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with both demo app and WPiOS app with a post that has Gallery block.

@mkevins mkevins merged commit d0085ea into master Dec 4, 2019
@mkevins mkevins deleted the fix/disable-gallery-for-now branch December 4, 2019 13:30
@youknowriad youknowriad added this to the Gutenberg 7.1 milestone Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees
No one assigned
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Milestone
Gutenberg 7.1
Development

Successfully merging this pull request may close these issues.
3 participants
@mkevins @pinarol @youknowriad